Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Event types on metric alerts #239

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Conversation

jianyuan
Copy link
Owner

@jianyuan jianyuan commented Dec 12, 2022

This is a follow-up to #237.

  1. Bump go-sentry to v2.1.1, which uses the get metric alerts endpoint that is nested under the "organisations" resource.
  2. Set event_types property during read
  3. Fix tests
  4. Populate data source

@jianyuan jianyuan force-pushed the fix-event-types-on-metric-alerts branch from e859c90 to 1c6cc69 Compare December 12, 2022 13:47
@jianyuan jianyuan force-pushed the fix-event-types-on-metric-alerts branch from 1c6cc69 to d8132ac Compare December 12, 2022 13:54
@jianyuan jianyuan merged commit 786461e into main Dec 12, 2022
@jianyuan jianyuan deleted the fix-event-types-on-metric-alerts branch December 12, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant