Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it working? #4

Open
Tufis16 opened this issue Jul 20, 2024 · 14 comments
Open

Is it working? #4

Tufis16 opened this issue Jul 20, 2024 · 14 comments

Comments

@Tufis16
Copy link

Tufis16 commented Jul 20, 2024

I tested on Unity 2022.3.22 and added in global volume and urp setting but nothing changed. Also changed forward/forward+/deffered not working.

@jiaozi158
Copy link
Owner

Hi, do you have SSGI enabled in the volume override?
SSGI_Volume_Override

@jiaozi158
Copy link
Owner

By the way, I suggest upgrading to a higher (patch) version of Unity Editor before installing this package, such as 2022.3.35f1.

There was a bug in older versions of URP related to the render queue, and I don't have time to find out which version it was fixed in.

@Tufis16
Copy link
Author

Tufis16 commented Jul 20, 2024

Yes it's enabled. I will test your recommended version and after i will tell the results. Thanks.

@Tufis16
Copy link
Author

Tufis16 commented Jul 20, 2024

Yeah i tested in clean Unity 2022.3.38 urp project and same. Can't see any diffrence. And yes everything attached and enabled.

@jiaozi158
Copy link
Owner

That's strange. Does the camera's active URP renderer have SSGI (renderer feature)?

Camera's renderer in use:
Camera_Renderer
URP renderer asset:
URP Renderer

@Tufis16
Copy link
Author

Tufis16 commented Jul 20, 2024

I tried but no.

@jiaozi158
Copy link
Owner

Could you provide a small project (ex. the empty project you created) so that I can reproduce the problem?

Project Folder
Thank you very much!

@Tufis16
Copy link
Author

Tufis16 commented Jul 30, 2024

Still same, i read all your replies. I follow this steps and more:
1- Download this "https://github.com/jiaozi158/UnitySSGIURP.git" with github "or just downloaded with zip"
2- Drag and dropped to project
3- Added to renderer feature and enabled
4- Added to Global Volume and enabled
5- Checked rendering pipelines "from cameras or graphics settings" no changes anything.

This is project:
https://we.tl/t-zCMD0JKSms

jiaozi158 added a commit that referenced this issue Jul 31, 2024
Changed:

- Changed shader includes from absolute paths to relative paths to avoid potential issues in certain situations. ("#4" and "#5")

Note:

It is recommended to Install via Package Manager for easier updates and better compatibility with version control.
@jiaozi158
Copy link
Owner

Hi, could you try again (the latest version) and see if the issue is resolved?

I downloaded the project you provided and found that it seems to be the same problem mentioned in #5.

@Tufis16
Copy link
Author

Tufis16 commented Aug 2, 2024 via email

@Tufis16
Copy link
Author

Tufis16 commented Aug 2, 2024

I think intensity is too low. Max value is 0.95. How can we make more saturated or high intensity?

@jiaozi158
Copy link
Owner

How can we make more saturated or high intensity?

Hi, the "0.95" value controls the intensity of temporal accumulation.

I think you're looking for the "Indirect Diffuse Lighting Multiplier".
Multiplier

@Tufis16
Copy link
Author

Tufis16 commented Aug 6, 2024

Yes i mean this! but it shows after setting "All Visible" "Show All Addinational Setting Properties"

Missing

All visible

@jiaozi158
Copy link
Owner

Thanks for reminding!

I don't think it should be an additional property, so I'll change that in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants