-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I don't know if it works or not? #5
Comments
Hi, I'm sorry to hear that! What Unity version does your project use? And is this issue reproducible in an empty URP project? I cannot reproduce it on my computer using Unity 2022.3.37f1 and 6000.0.5f1. |
I'm using Unity 2022.3.39f and I'm not sure what you mean about reproducing. |
Do you have Git installed on your computer? Or, you can try manually installing the package: |
Thank you so much I have many questions 1. You are the only person who brought HDRP urp and with path tracing have you ever considered GTAO or a different solution like sign distance field or Radiance Cascades. |
Please make a dicord. 👍 💯 |
Glad to hear that it’s working! I chose the screen space solution because it is easier to implement and works well with other custom features. In the future, RTGI can also be added on top of it. I don’t have plans to try other global illumination solutions yet, mainly because there are higher priority features to complete. As for Discord channel, I may consider it later, but I doubt if this is necessary. |
If screen space is easy you check this old website that uses Dynamic, Noise Free, Screen Space Diffuse Global Illumination |
Thank you for these suggestions, and sorry for the late reply! I heard that some devs may deprecate their assets (or repos) if there's minimum usage. All my repos are actually for a future project (but may never start), so I'll try my best to improve them even if they get little attention. This is my first time creating a UPM package (SSGI), and it requires a different installation method. I'll update the shader includes to use relative paths so that people can install it as they prefer. |
It works perfectly with no issues and no errors performance is better than Hdrp again thank you but other than that it works hope you can add more features this is great. |
Have you ever considered ambient occlusion like RTAO to replace the regular URP ambient occlusion? |
Thanks, I'll continue to improve it when I have time!
I don’t have plans for ambient occlusion yet, because in theory, AO is an approximation of GI. However, you can still use both in a project, just make sure the result looks good. |
I see what you mean I'm using HBAO and with the ssgi, it makes the ambient occlusion better. |
Is there any hope of updating the path-tracing ssgi I like the stacking it has with Regular ssgi? |
Do you mean improving the "UnitySSPathTracingURP" repo? Path tracing is very helpful for realistic rendering, and I have many ideas to improve the repo (more material types & denoising), but it takes a lot of time to try and implement. So, I plan to continue adding another feature (ex. sky improvements) to URP first. |
Cool, I hope you can find a team to help you with your projects someday. It would be a waste to lose. |
Hey like the update for indirect there maybe a problem with the vegetation it makes ghosting noises when moving the camera. |
Does this occur in older versions of SSGI? Additionally, how do you render the vegetation? For example, the ghosting issue can be due to incorrect motion vectors. |
well i'm using unity 2022 version don't know what you mean of incorrect motion vectors. |
Motion vectors are 2D coordinates that describe the movement of screen pixels from the previous frame to the current frame. Currently, the denoiser relies heavily on them to avoid ghosting. Can you try disabling SSGI and check if there's severe ghosting in the game view on the vegetation when using TAA? Regarding the problem, do you use terrain details to place the vegetation? That could be the cause of incorrect motion vectors, AFAIK. |
Oh okay sorry friend it works fine was using FSR3 when switched off the ghosting was gone. |
If FSR2 or 3 is causing ghosting, there might still be a problem with the motion vectors. That's interesting because I didn't expect the SSGI denoiser would work with incorrect motion vectors. |
I'm using with asset store fsr 3 |
I suggest contacting the FSR3 publisher for support, as they’re more familiar with the asset. Feel free to discuss with me if you have any questions with SSGI! |
Hey, these guys just put out SSRT3 on GitHub. Might want to check it out. https://github.com/cdrinmatane/SSRT3 |
Thanks for reminding, will check it out when I have time and share my thoughts and findings here! |
Hey, I'm letting you know I like the sky and APV update but I think the performance went down a little I was at 32 fps and dropped to 26- 28ish again I don't know and I'm going to showcase the ssgi I'm making a game also so that would be great have lots of people in differ discords that would love to hear about you this a guy that is making Nanite for unity called Nano Tech he would gladly help you well he has a full team also he has guy for shadows, AO , and ssgi but he went quite but the guy running Nano Tech name Chris Khaler he a good man he's going to make unity great but again keep going please. :) |
Can you try to confirm if the framerate still drops when “Ray Miss" is set to "Reflection Probes"? I'll further optimize the 2 new fallback options in future updates. (especially the APV)
Thanks! I've seen his post (and impressive demo videos) on the old forum. Also glad to hear the project is still active, especially since many community members and Unity staff seem to have left Unity in recent years. |
So, I download from get git hub first everything was setup from adding in the ssgi in urp render and looking at the camera inspector, but it didn't work. then using unity package manager url I added the website to the url still didn't work. I hope the developer can fix these issues really like his work cause the path trace ssgi works but could use a better denoiser, but it still works and it's almost better then HDRP performance. I get around 35 fps or less using Hdrp ssgi with path trace ssgi I am getting around 78 plus using fsr 3 on the unity asset store getting around 90 or higher fps. Thats why I'm curious about ssgi if they are not the same just hoping the developer will continue these graphical projects especially ssgi for urp amazing you are the only person doing unity's work thanks. 👍
The text was updated successfully, but these errors were encountered: