jpmorganchase#109 Moved errorprone configuration out of a profile and…

… into the compiler plugin configuration Moved errorprone configuration out of profile and into the compiler plugin configuration since all issues that errorprone detected were intentional decisions.
jimbethancourt · Jun 21, 2020 · 69c2f32 · 69c2f32
1 parent b65150e
commit 69c2f32
Showing 1 changed file with 16 additions and 35 deletions.
diff --git a/pom.xml b/pom.xml
@@ -163,41 +163,6 @@
             </build>
 
         </profile>
-        <profile>
-            <id>errorprone</id>
-            <build>
-                <plugins>
-                    <plugin>
-                        <groupId>org.apache.maven.plugins</groupId>
-                        <artifactId>maven-compiler-plugin</artifactId>
-                        <version>${maven-compiler-plugin.version}</version>
-                        <configuration>
-                            <source>${mvn.compiler.source}</source>
-                            <target>${mvn.compiler.target}</target>
-                            <compilerArgs>
-                                <arg>-XDcompilePolicy=simple</arg>
-                                <arg>-Xplugin:ErrorProne</arg>
-                            </compilerArgs>
-                            <annotationProcessorPaths>
-                                <path>
-                                    <groupId>org.projectlombok</groupId>
-                                    <artifactId>lombok</artifactId>
-                                    <version>${lombok.version}</version>
-                                </path>
-                                <path>
-                                    <groupId>com.google.errorprone</groupId>
-                                    <artifactId>error_prone_core</artifactId>
-                                    <version>${errorprone.version}</version>
-                                </path>
-
-                                <!-- Add any other annotation processors here,
-                                     even if they are also on the project dependency classpath. -->
-                            </annotationProcessorPaths>
-                        </configuration>
-                    </plugin>
-                </plugins>
-            </build>
-        </profile>
         <profile>
             <id>jdk8-errorprone-addendum</id>
             <activation>
@@ -263,6 +228,22 @@
                 <configuration>
                     <source>${mvn.compiler.source}</source>
                     <target>${mvn.compiler.target}</target>
+                    <compilerArgs>
+                        <arg>-XDcompilePolicy=simple</arg>
+                        <arg>-Xplugin:ErrorProne</arg>
+                    </compilerArgs>
+                    <annotationProcessorPaths>
+                        <path>
+                            <groupId>org.projectlombok</groupId>
+                            <artifactId>lombok</artifactId>
+                            <version>${lombok.version}</version>
+                        </path>
+                        <path>
+                            <groupId>com.google.errorprone</groupId>
+                            <artifactId>error_prone_core</artifactId>
+                            <version>${errorprone.version}</version>
+                        </path>
+                    </annotationProcessorPaths>
                 </configuration>
             </plugin>
             <plugin>