Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Add Google Errorprone in a Maven profile #109

Open
jimbethancourt opened this issue May 29, 2020 · 0 comments
Open

Add Google Errorprone in a Maven profile #109

jimbethancourt opened this issue May 29, 2020 · 0 comments

Comments

@jimbethancourt
Copy link
Contributor

Add google errorprone in a Maven profile to allow for optional inclusion and avoid needing to fix all issues immediately that errorprone finds. IntelliJ and the Maven errorprone compiler plugin also don't seem to play nicely together, and adding errorprone in a profile works around this issue.

jimbethancourt added a commit to jimbethancourt/sandboni-core that referenced this issue May 29, 2020
Added Google Errorprone profile.  To activate, specify mvn clean compile -Perrorprone on the command line.
jimbethancourt added a commit to jimbethancourt/sandboni-core that referenced this issue Jun 14, 2020
Added Google Errorprone profile.  To activate, specify mvn clean compile -Perrorprone on the command line.
jimbethancourt added a commit to jimbethancourt/sandboni-core that referenced this issue Jun 14, 2020
…rone will ignore since this design is intentional

Adding "FunctionalInterfaceMethodChanged" suppression for ErrorProne since this design is intentional.  See https://errorprone.info/bugpattern/FunctionalInterfaceMethodChanged
jimbethancourt added a commit to jimbethancourt/sandboni-core that referenced this issue Jun 14, 2020
Adding Lombok path to the annotation processor path in the Errorprone profile to allow both Lombok and Errorprone annotation processing to take place.  See google/error-prone#1185
jimbethancourt added a commit to jimbethancourt/sandboni-core that referenced this issue Jun 14, 2020
…ibility

Still having issues with errorprone & lombok compatibility.  Added comment to profile.
jimbethancourt added a commit to jimbethancourt/sandboni-core that referenced this issue Jun 21, 2020
…works!!!

Full compilation with errorprone and lombok works!!!  Had to follow instructions provided on https://errorprone.info/docs/installation precisely.
jimbethancourt added a commit to jimbethancourt/sandboni-core that referenced this issue Jun 21, 2020
…warning from ErrorProne

Suppressing the "FunctionalInterfaceMethodChanged" warning from ErrorProne since this was a deliberate design decision.
jimbethancourt added a commit to jimbethancourt/sandboni-core that referenced this issue Jun 21, 2020
jimbethancourt added a commit to jimbethancourt/sandboni-core that referenced this issue Jun 21, 2020
… into the compiler plugin configuration

Moved errorprone configuration out of profile and into the compiler plugin configuration since all issues that errorprone detected were intentional decisions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant