switch from browserify to webpack #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
commented
Feb 4, 2023
| @@ -10,5 +10,7 @@ runs: | |||
| path: | | |||
| node_modules | |||
| packages/*/dist | |||
| packages/*/es | |||
| packages/jimp/browser/lib | |||
There was a problem hiding this comment.
We weren't caching all the build files so that's why they weren't there
hipstersmoothie
commented
Feb 4, 2023
| @@ -77,21 +77,6 @@ If you're using a web bundles (webpack, rollup, parcel) you can benefit from usi | |||
| import Jimp from "jimp/es"; | |||
| ``` | |||
|
|
|||
| ### WebPack | |||
|
|
|||
| If you're using webpack you can set `process.browser` to true and your build of jimp will exclude certain parts, making it load faster. | |||
There was a problem hiding this comment.
This isn't a problem anymore and was always a misunderstanding on how to make a browser bundle 😓
hipstersmoothie
commented
Feb 4, 2023
| "typesVersions": { | ||
| ">=3.1.0-0": { | ||
| "*": [ | ||
| "types/ts3.1/index.d.ts" |
There was a problem hiding this comment.
I'm not interested in supporting ancient TS versions
hipstersmoothie
commented
Feb 4, 2023
| const isProd = process.env.NODE_ENV === "production"; | ||
|
|
||
| export default { | ||
| mode: isProd ? "production" : "development", |
There was a problem hiding this comment.
Webpack is sooooo much simpler than a custom browserify scrip
hipstersmoothie
commented
Feb 4, 2023
| @@ -24,7 +24,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.7.2", | |||
| "pngjs": "^3.3.3" | |||
| "pngjs": "^6.0.0" | |||
There was a problem hiding this comment.
Upgraded pngjs along the way too
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1139
closes #1132
📦 Published PR as canary version:
0.17.9--canary.1140.e3ff49d.0✨ Test out this PR locally via:
npm install @jimp/cli@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/core@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/custom@0.17.9--canary.1140.e3ff49d.0 npm install jimp@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-blit@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-blur@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-circle@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-color@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-contain@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-cover@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-crop@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-displace@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-dither@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-fisheye@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-flip@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-gaussian@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-invert@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-mask@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-normalize@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-print@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-resize@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-rotate@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-scale@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-shadow@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugin-threshold@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/plugins@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/test-utils@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/bmp@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/gif@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/jpeg@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/png@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/tiff@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/types@0.17.9--canary.1140.e3ff49d.0 npm install @jimp/utils@0.17.9--canary.1140.e3ff49d.0 # or yarn add @jimp/cli@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/core@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/custom@0.17.9--canary.1140.e3ff49d.0 yarn add jimp@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-blit@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-blur@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-circle@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-color@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-contain@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-cover@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-crop@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-displace@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-dither@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-fisheye@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-flip@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-gaussian@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-invert@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-mask@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-normalize@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-print@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-resize@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-rotate@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-scale@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-shadow@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugin-threshold@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/plugins@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/test-utils@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/bmp@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/gif@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/jpeg@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/png@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/tiff@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/types@0.17.9--canary.1140.e3ff49d.0 yarn add @jimp/utils@0.17.9--canary.1140.e3ff49d.0Release Notes
This PR can be considered a breaking change as it remove the
jimp.min.jsfile.Instead there is now only the
jimp.jsfile and we ship source maps for it.We also configured the
browserfield so jimp will be automatically bundled better