Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Session dialog does not handle keys correctly #437

Closed
GoogleCodeExporter opened this issue May 8, 2015 · 4 comments
Closed

Open Session dialog does not handle keys correctly #437

GoogleCodeExporter opened this issue May 8, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Open the Open Session dialog (<CTRL-O>)
2. Type in the first letters of the session you want to open
3a. If the first entry is the required session, pressing enter should open the 
session

3b. Browsing through the list if a filter is active by pressing the up and down 
keys

What is the expected output? What do you see instead?
3a. The session should open but in stead, a beep sounds and nothing happens

3b. The selector should move up and down the list but it looks like the second 
keystroke is ignored.

What version of the product are you using? On what operating system?
1.4.0.5 on Windows 7 32bit

Please provide any additional information below.

Original issue reported on code.google.com by dajo...@gmail.com on 24 Jun 2014 at 6:06

@GoogleCodeExporter
Copy link
Author

I noticed too late that this issue is closely related to issue #421

Original comment by dajo...@gmail.com on 24 Jun 2014 at 6:09

@GoogleCodeExporter
Copy link
Author

All you need to do (assuming you have Visual Studio) is change the following 
code in QuickSelector.cs

        private void textBoxData_KeyDown(object sender, KeyEventArgs e)
        {
            switch (e.KeyCode)
            {
                case Keys.Enter:
                    if (this.DataView.Count > 0) // Changed from == 1 to > 0 so as long as there's 1 or more, it'll select the first in the list which is usually the highlighted on.
                    {
                        this.DoSelectItem();
                    }
                    break;

Seems like the maintainers are taking a break from coding.

Original comment by djtrem...@gmail.com on 10 Jul 2014 at 10:52

@GoogleCodeExporter
Copy link
Author

All you need to do (assuming you have Visual Studio) is change the following 
code in QuickSelector.cs

        private void textBoxData_KeyDown(object sender, KeyEventArgs e)
        {
            switch (e.KeyCode)
            {
                case Keys.Enter:
                    if (this.DataView.Count > 0) // Changed from == 1 to > 0 so as long as there's 1 or more, it'll select the first in the list which is usually the highlighted on.
                    {
                        this.DoSelectItem();
                    }
                    break;

Seems like the maintainers are taking a break from coding.

Original comment by djtrem...@gmail.com on 10 Jul 2014 at 10:52

simono74 added a commit to simono74/superputty-1 that referenced this issue Sep 25, 2015
… window and change the default value of QuickSelectorCaseSensitiveSearch to false.
jimradford added a commit that referenced this issue Sep 26, 2015
Fixes Issue #437 - Open Session dialog does not handle keys correctly
@jimradford jimradford added this to the v1.4.0.8 milestone Sep 26, 2015
@jimradford
Copy link
Owner

@simono74 Thanks for the Fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants