#437 - Fix the way the keys are handled in the open session window an… #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… window and change the default value of QuickSelectorCaseSensitiveSearch to false.
jimradford
added a commit
that referenced
this pull request
Sep 26, 2015
Fixes Issue #437 - Open Session dialog does not handle keys correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the key handling in the Open Session window (Issue #437). The enter key now starts the selected session even if there are multiple sessions listed in the window. The Up/Down keys behavior is also fixed. The problem was that the second row of the table was selected when the user pressed the down key, but the current cell wasn't changed at the same time. Since the current cell was still the one from the first row, nothing happened when the user pressed the up key afterwards.
I also changed the default value of QuickSelectorCaseSensitiveSearch to false since I think this behavior makes a lot more sense.