This repository has been archived by the owner on Jul 27, 2021. It is now read-only.
refactor: CI, integration tests, cleanup #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianmtr
force-pushed
the
feat-psql-20
branch
3 times, most recently
from
9f9ad47 to
8f3d108
Compare
cristianmtr
force-pushed
the
feat-psql-20
branch
2 times, most recently
from
df6b97b to
460acc5
Compare
jinahub/indexers/query/keyvalue/PostgreSQLQueryIndexer/README.md
Outdated
Show resolved
Hide resolved
cristianmtr
force-pushed
the
feat-psql-20
branch
14 times, most recently
from
2c6f4b7 to
8cfb89a
Compare
maximilianwerk
suggested changes
Jun 9, 2021
| password=self.password, | ||
| database=self.database, | ||
| table=self.table) | ||
|
|
||
| def get_handler(self) -> 'PostgreSQLDBMSHandler': |
There was a problem hiding this comment.
These get_XXX_handler functions are a smell to me. Just use self.handler.
There was a problem hiding this comment.
I think those were necessary because of the BaseIndexer's close call, which would call these. Removed
| @@ -58,22 +69,12 @@ def size(self): | |||
| .. # noqa: DAR201 | |||
| """ | |||
| with self.handler as postgres_handler: | |||
There was a problem hiding this comment.
I am not convinced of opening/closing connection with every operation. This creates quite some overhead, especially when the database is running on a distance machine. Why not open the connection once and keep it open?
jinahub/indexers/query/compound/NumpyPostgresQueryIndexer/requirements.txt
Outdated
Show resolved
Hide resolved
This was referenced Jun 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of jina-ai/serve#2560 and jina-ai/serve#2479