Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move integration tests to 2.0 #2479

Closed
36 tasks done
FionnD opened this issue May 25, 2021 · 2 comments
Closed
36 tasks done

Move integration tests to 2.0 #2479

FionnD opened this issue May 25, 2021 · 2 comments
Assignees
Labels
area/core This issue/PR affects the core codebase component/executor component/flow epic/2.0 All tasks related to development on 2.0 priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed.

Comments

@FionnD
Copy link
Contributor

FionnD commented May 25, 2021

Describe the feature
As we move towards 2.0, we need to redo each of our current integration tests and update them to the new codebase.

Integration tests in 1.x

When moving tests from issues to somewhere else, keep the issue ID in the docstring of the test.

TO WORK ON THIS

  1. Put your name on a task you pick
  2. Open a PR
  3. Add the PR next to the checkbox
  4. Tick the checkbox once the PR is done

(check first item below)

@FionnD FionnD added the epic/2.0 All tasks related to development on 2.0 label May 25, 2021
@cristianmtr
Copy link
Contributor

cristianmtr commented May 28, 2021

Some comments:

crud -- I guess here we would be testing on dummy Executors in the core?

dump -- This is there, but it's the DocumentArray.save implementation. The plan is to have the hub module of PSQLIndexer be the one that implements the exports and imports. Then people needing those would need to import that module. https://jinaai.slack.com/archives/C018F60RBL5/p1622190316138700?thread_ts=1622188950.135200&cid=C018F60RBL5

@cristianmtr
Copy link
Contributor

@CatStark can we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/executor component/flow epic/2.0 All tasks related to development on 2.0 priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed.
Projects
None yet
Development

No branches or pull requests

3 participants