Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added optimizer integration test back #2519

Merged
merged 1 commit into from
May 31, 2021

Conversation

maximilianwerk
Copy link
Member

PR for adding back the optimizer test and adopt the optimizer to the 2.0 API.

@maximilianwerk maximilianwerk requested a review from a team as a code owner May 31, 2021 11:47
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels May 31, 2021
@maximilianwerk maximilianwerk mentioned this pull request May 31, 2021
36 tasks
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #2519 (16eb8fd) into master (7d901e8) will increase coverage by 2.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2519      +/-   ##
==========================================
+ Coverage   83.46%   86.04%   +2.57%     
==========================================
  Files         152      152              
  Lines        9417     9415       -2     
==========================================
+ Hits         7860     8101     +241     
+ Misses       1557     1314     -243     
Flag Coverage Δ
daemon 46.79% <0.00%> (+<0.01%) ⬆️
jina 86.02% <100.00%> (+2.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/optimizers/__init__.py 87.61% <100.00%> (+87.61%) ⬆️
jina/optimizers/flow_runner.py 97.67% <100.00%> (+97.67%) ⬆️
jina/peapods/pods/__init__.py 85.40% <0.00%> (-4.66%) ⬇️
jina/jaml/parsers/__init__.py 100.00% <0.00%> (+7.31%) ⬆️
jina/optimizers/parameters.py 67.50% <0.00%> (+67.50%) ⬆️
jina/optimizers/discovery.py 80.26% <0.00%> (+80.26%) ⬆️
jina/parsers/optimizer.py 100.00% <0.00%> (+100.00%) ⬆️
jina/jaml/parsers/default/v1.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da1d47...16eb8fd. Read the comment docs.

@maximilianwerk maximilianwerk merged commit d4968e6 into master May 31, 2021
@maximilianwerk maximilianwerk deleted the tests-add-optimizer-tests branch May 31, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants