Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: crud rest #2525

Merged
merged 1 commit into from
Jun 1, 2021
Merged

test: crud rest #2525

merged 1 commit into from
Jun 1, 2021

Conversation

cristianmtr
Copy link
Contributor

Part of #2479

@cristianmtr cristianmtr requested a review from a team as a code owner May 31, 2021 17:25
@cristianmtr cristianmtr requested review from CatStark and JoanFM May 31, 2021 17:25
@cristianmtr cristianmtr mentioned this pull request May 31, 2021
36 tasks
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #2525 (f667737) into master (60ee474) will increase coverage by 0.48%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2525      +/-   ##
==========================================
+ Coverage   85.61%   86.10%   +0.48%     
==========================================
  Files         152      152              
  Lines        9462     9462              
==========================================
+ Hits         8101     8147      +46     
+ Misses       1361     1315      -46     
Flag Coverage Δ
daemon 46.82% <66.66%> (ø)
jina 86.09% <83.33%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/builder.py 96.25% <83.33%> (ø)
jina/helper.py 78.44% <0.00%> (+0.38%) ⬆️
jina/flow/base.py 90.59% <0.00%> (+0.91%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.80% <0.00%> (+0.95%) ⬆️
jina/peapods/peas/__init__.py 96.72% <0.00%> (+2.45%) ⬆️
jina/peapods/runtimes/asyncio/rest/app.py 91.37% <0.00%> (+3.44%) ⬆️
jina/peapods/pods/compound.py 90.97% <0.00%> (+23.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01e63d...f667737. Read the comment docs.

Copy link
Member

@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first reaction was: That should be two separate tests.

But actually, I really like, that for each step you directly see how a rest request and a grpc requests relate. Really nice!

@cristianmtr
Copy link
Contributor Author

My first reaction was: That should be two separate tests.

But actually, I really like, that for each step you directly see how a rest request and a grpc requests relate. Really nice!

Yeah, I thought it would be useful to have it in one place, for comparison

@cristianmtr cristianmtr merged commit 01e339a into master Jun 1, 2021
@cristianmtr cristianmtr deleted the test-crud-rest branch June 1, 2021 08:35
JoanFM pushed a commit that referenced this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants