update to v3 api #10
Closed
update to v3 api #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solsson
reviewed
Jan 19, 2018
| @@ -5,11 +5,11 @@ RUN go get github.com/Masterminds/glide | |||
| WORKDIR /go/src/github.com/jirwin/burrow_exporter | |||
| COPY . /go/src/github.com/jirwin/burrow_exporter | |||
| RUN glide install | |||
| RUN go build burrow-exporter.go | |||
| RUN go build -o burrow-exporter | |||
There was a problem hiding this comment.
This is the only difference I can see from #9. What does it do?
|
It makes sure output file is named "burrow-exporter". It is the same as calling "go build burrow-exporter.go" only more standard |
|
One small detail: I haven't used v2, not sure what this metric means, but the Burrow wiki for v3 doesn't mention this metric. Also I've just tested on Burrow v3, it's not exposing this field. (commenting this on another PR too, not sure which will be the final one) |
|
Closing this since I merged #12. Thanks for submitting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.