-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Burrow API v3 #9
Conversation
63de275 was done only to speed up image pull for the pod. I can revert that if the PR ever gets close to mergeable state. |
With the fix above I get the following exports for a mini cluster:
@VictorBHub does this look like an ok fix for #8 ? I've built |
looks great.. |
One small detail: I haven't used v2, not sure what this metric means, but the Burrow wiki for v3 doesn't mention this metric. Also I've just tested on Burrow v3, it's not exposing this field. (commenting this on another PR too, not sure which will be the final one) |
Does this break compatibility with the v2 api? I'd merge a change that didn't. |
@jirwin Burrow broke backward compat when they went from v2 to v3 (the uri changed among other schema changes). This will break people using Burrow v2. |
Extremely quick shot at #8 to have something to scrape in Yolean/kubernetes-kafka#125.
The only useful value in
:8080/metrics
after the initial commit iskafka_burrow_topic_partition_offset
.