-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support rtl layout #11079
feat: support rtl layout #11079
Conversation
"prejoin-preview-dropdown-btn" and "prejoin-preview-dropdown-icon" styles are already declared using jss in DropdownButton component.
….scss "action-btn" styles are already declared using jss in ActionButton component.
Hi, thanks for your contribution! |
Amazing work, thank you! |
@saghul If you are willing to support RTL layout, I think it would be a good idea to encourage contributors to use JSS instead of Sass in their new pull requests. |
Yep, JSS is where we are headed. Now, this PR is huge, which means it will be hard to review and keep up to date with our own ongoing work. Any chance you can break it down into smaller chunks, so we can start merging them one by one? |
Oh I must have missed those, thanks for the reminder! |
Closing this since it has been broken down into smaller PRs. Amazing work @c0m1t ! |
This pull requests allows the web app to change layout(direction) based on the language selected by the user. For languages like Persian or Arabic, it will be RTL.
Apparently it is not possible to support RTL using Sass. So I converted Sass styles to JSS, so with the help of
rtl
plugin fromjss-rtl
properties can be flipped. (for examplepadding-left
would change topadding-right
).I kept the main layout the same, participants pane is still on the right, chat pane is still on the left, filmstrips are still on the right side, ... .
Prejoin:
Main layout:
Chat panel:
Overflow menu:
Dialogs:
Filmstrips: