Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rtl layout #11079

Closed
wants to merge 42 commits into from
Closed

feat: support rtl layout #11079

wants to merge 42 commits into from

Conversation

c0m1t
Copy link

@c0m1t c0m1t commented Mar 6, 2022

This pull requests allows the web app to change layout(direction) based on the language selected by the user. For languages like Persian or Arabic, it will be RTL.

Apparently it is not possible to support RTL using Sass. So I converted Sass styles to JSS, so with the help of rtl plugin from jss-rtl properties can be flipped. (for example padding-left would change to padding-right).

I kept the main layout the same, participants pane is still on the right, chat pane is still on the left, filmstrips are still on the right side, ... .

Prejoin:
Screen Shot 1400-12-15 at 22 02 25

Main layout:
Screen Shot 1400-12-15 at 22 03 09

Chat panel:
Screen Shot 1400-12-15 at 22 03 32

Overflow menu:
Screen Shot 1400-12-15 at 22 03 48

Dialogs:
Screen Shot 1400-12-15 at 22 03 59

Filmstrips:
Screen Shot 1400-12-15 at 22 04 41

c0m1t added 30 commits March 6, 2022 21:06
"prejoin-preview-dropdown-btn" and "prejoin-preview-dropdown-icon" styles are already declared using jss in DropdownButton component.
….scss

"action-btn" styles are already declared using jss in ActionButton component.
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul
Copy link
Member

saghul commented Mar 7, 2022

Amazing work, thank you!

@c0m1t
Copy link
Author

c0m1t commented Mar 12, 2022

@saghul If you are willing to support RTL layout, I think it would be a good idea to encourage contributors to use JSS instead of Sass in their new pull requests.

@saghul
Copy link
Member

saghul commented Mar 12, 2022

Yep, JSS is where we are headed.

Now, this PR is huge, which means it will be hard to review and keep up to date with our own ongoing work.

Any chance you can break it down into smaller chunks, so we can start merging them one by one?

@c0m1t
Copy link
Author

c0m1t commented Mar 12, 2022

Sure.

Btw I already submitted these 2 pull requests 2 weeks ago #11038 and #11037.

@saghul
Copy link
Member

saghul commented Mar 12, 2022

Oh I must have missed those, thanks for the reminder!

@saghul
Copy link
Member

saghul commented Mar 15, 2022

Closing this since it has been broken down into smaller PRs. Amazing work @c0m1t !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants