Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move chat component outside of videoconference_page #11138

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

c0m1t
Copy link

@c0m1t c0m1t commented Mar 15, 2022

Move Chat component one level up, to be placed next to the ParticipantsPane and div#videoconference_page in Conference component.

@c0m1t
Copy link
Author

c0m1t commented Mar 15, 2022

This is a commit cherry picked from #11079. This PR will remove some unnecessary complexity and make it easier to support RTL.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@robertpin robertpin self-requested a review March 16, 2022 10:18
@c0m1t c0m1t force-pushed the move-chat-component branch from f11d7cc to b5c8262 Compare March 29, 2022 07:19
@c0m1t c0m1t requested a review from robertpin March 29, 2022 08:02
@robertpin robertpin merged commit 3eafaee into jitsi:master Mar 29, 2022
@c0m1t c0m1t deleted the move-chat-component branch March 29, 2022 09:35
jallamsetty1 pushed a commit to jallamsetty1/jitsi-meet that referenced this pull request Mar 30, 2022
pull bot pushed a commit to e4basil/jitsi-meet that referenced this pull request Mar 30, 2022
ankit-programmer pushed a commit to ankit-programmer/jitsi-meet that referenced this pull request May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants