Issue244 remove hosts #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asserts that test(all_symbols) == test(found_symbols) after all is said and done.
Issue225 bisect assert disjoint
This allows header files to be missing without Makefile errors
- Comment about result_queue.put() describing why it is there - Reraise the exception so that the exception will be printed to stderr for debugging
Under --verbose, subp.Popen() is used incorrectly and can still cause a deadlock. This is now fixed.
issue230 Make with missing headers
Issue229 bisect deadlock
Issue194 templated functions
Apparrently the ModuleNotFoundError was introduced as a subclass of ImportError in python 3.6. To support older versions of python 3, we need to catch ImportError instead
Issue238 bisect reduce symb
put an explanatory section saying future feature
|
I will be working on merging our two implementations from this merged baseline. Once this pull request is completed, I will be able to make the next pull request containing my merge of our two approaches. Thanks again JJ. |
|
Actually, I'll make another pull request. I didn't intend for the merge to be also in the other pull request on PRUNERS. I'll make a separate branch for doing this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
This removes the
[[hosts]]field fromflit-config.toml. This hasn't yet been incorporated into thedevelbranch inPRUNERS/FLiT, but I suspect it will. This merge also brings this feature branch up to date with thedevelbranch found inPRUNERS/FLiT.This is a common baseline to start from before merging our two implementations of moving the flags into the toml file.
Note: I am doing a pull request into the branch attached to your pull request. This is how I think it will be best to merge our two implementations and use your existing pull request. As you accept pull requests from me into your feature branch, your open pull request into
PRUNERS/FLiTwill be automatically updated to the head of your feature branch.