-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TZID requires luxon warning, when I have Luxon already #427
Comments
I think this issue started from 2.6.6? It should not just be a warning, should just throw an error, and in a real application, replace the timezone with UTC will cause serious business issues (in my case I'm writing a medical appointment system, this change caused all the appointments having wrong start time). |
I can confirm roll back to
|
I confirm the issue. Luxon is never found in 2.6.6 and a warning is displayed. |
i am doing a rollup that includes the rrule module and am getting this...
|
|
How do I include Luxon again? I have it on my npm modules but rrule is not working as it was 2.6.4 I get the error |
Is it viable to add a test for that? To test that Luxon plugs in. |
For anyone still facing this issue, #410 is the PR of reference. Basically, if you are using commonjs module system, you can no longer provide luxon as it automatically replaced with fake_luxon. I would suggest anyone with this problem to stick it to 2.6.4 if possible. or you have to switch to es module system. |
* Downgraded rrule to 2.6.4 until this is fixed: jkbrzt/rrule#427 * Construct RRule with original datestring and timezone Co-authored-by: Jens Maus <mail@jens-maus.de>
@lxcid thank you for your advice to stick to 2.6.4. |
I ran into this problem on version 2.6.8 and 2.6.4. I wanted to make a test case in this Issue to show that the solution does not help, however, I found the cause of the warning. It occurs only when the object has a There is a warning: {
tzid: 'Europe/Moscow',
dtstart: 2022-01-04T17:00:00.000Z,
until: 2022-12-31T20:59:59.000Z,
freq: 2,
interval: 1,
wkst: 0,
byweekday: [ 1 ],
byhour: [ 17 ],
byminute: [ 0 ],
bysecond: [ 0 ]
} No warning: {
dtstart: 2022-01-04T17:00:00.000Z,
until: 2022-12-31T20:59:59.000Z,
freq: 2,
interval: 1,
wkst: 0,
byweekday: [ 1 ],
byhour: [ 17 ],
byminute: [ 0 ],
bysecond: [ 0 ]
} Now I just remove this property, as it does not affect the functionality of my application in any way. |
Luxon is no longer used as of 2.7.0 |
Code sample reproducing the issue. Be sure to include all input values you
See https://stackoverflow.com/questions/64299310/rrule-using-tzid-without-luxon-available-is-unsupported for issue details
Expected output
No warnings
Actual output
Using TZID without Luxon available is unsupported. Returned times are in UTC, not the requested time zone
The version of
rrule
you are usingLatest
Your operating system
Ubuntu 18.04
Your local timezone
Europe/London
The text was updated successfully, but these errors were encountered: