Luxonless binary should not contain any luxon imports.

[samouri]

summary
Fixes #344, and maybe #402.

Currently the build produced without timezone support still references luxon and expects the code to throw a TypeError if incorrectly used (done via webpack externals). You can verify this by searching for "luxon" within the contents of dist/es5/rrule.min.js.

This causes issue when mixed with compilers that don't have the same notion of an external, e.g. Closure Compiler (google/closure-compiler#954). Specifically, the AMP Project is running into when trying to build rrule into our amp-date-picker component (ampproject/amphtml#28887).

This PR uses NormalModuleReplacementPlugin to replace luxon with a fake implementation that immediately throws.

[samouri]

@jakubroztocil / @davidgoli: friendly ping 🏓

[jkbrzt]

Thanks!

[samouri]

Thank you for merging this fix!
Not that there's any rush, but what's the release process like?

[jkbrzt]

@samouri I hope to find a time for it over the weekend (unless @davidgoli beats me to it).

Out of curiosity—what is your rrule.js use case?

[samouri]

@samouri I hope to find a time for it over the weekend (unless @davidgoli beats me to it).

Awesome!

Out of curiosity—what is your rrule.js use case?

I work for AMP, and we use rrule.js in the amp-date-picker component to support the highlighted/blocked attributes. We've managed to work around this issue in the meantime by manually patching the node_modules folder. See:

https://github.com/ampproject/amphtml/blob/a28fa129d225ce79d6b537f500c4540ae844caae/build-system/tasks/update-packages.js#L108-L119

[jkbrzt]

@samouri thanks for the background. v2.6.5 is out — https://www.npmjs.com/package/rrule The build process is broken, will need to fix that first.