Invalid date checks #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/rrule.js
Outdated
| return date instanceof Date; | ||
| }, | ||
|
|
||
| isValid: function (date) { |
There was a problem hiding this comment.
I think a better name would be isValidDate()
# By Linquize (2) and others # Via Jakub Roztočil (4) and Jakub Roztocil (2) * 'master' of https://github.com/jakubroztocil/rrule: Undo jkbrzt#91 as it was breaking the demo app Allow Negative and 2-Digit Values in Demo Bugfix Fix typo Do not hang if interval is 0 or not a number Updating script location in Bower, fixes jkbrzt#61.
* 'master' of https://github.com/aramk/rrule: Renamed isValid() to isValidDate().
|
Hi! I'm trying to clear out bugs and PRs. If this PR is still wanted/relevant, please comment and/or fix the conflicts! |
ghost
mentioned this pull request
|
This PR is too out of date to merge at this point, however, the functionality is still welcome in a new PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, this is a very useful library! I ran into an issue where I incorrectly parsed a date and passed it into
between(), which caused an infinite loop since it treated the date similar toundefined. While we may expect the iterator to be called indefinitely (until we return a falsy result) when we provide a falsy before date, it's likely an error on our part if we pass in anInvalid Date. I've added a check ininit()to fail on that along with some tests. I also added two small methods for checking if an object is a date and whether it's valid.