fix bug that the min and max elem in middleSplit_ is wrong sometimes. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ometimes. if span is always equal to max_span and equal to 0,if condition(span > (1 - EPS) * max_span) is always false, the min_elem and max_elem are always the default initailized value 0, this is a bug. so the max_elem and min_elem should inlitialized while setting max_span. This bug could be occur while there all the points which has the same location(x,y,z).
fix bug that the min and max elem in function middleSplit_ is wrong sometimes.
|
test data, a large numer of points which have the same negative coordinate could trigger this issue |
|
Hi @YongZouGN ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if span is always equal to max_span and equal to 0,if condition(span > (1 - EPS) * max_span) is always false, the min_elem and max_elem are always the default initailized value 0, this is a bug. so the max_elem and min_elem should inlitialized while setting max_span.
This bug could be occur while there all the points which has the same location(x,y,z).