Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug that the min and max elem in middleSplit_ is wrong sometimes. #231

Closed
wants to merge 2 commits into from
Closed

fix bug that the min and max elem in middleSplit_ is wrong sometimes. #231

wants to merge 2 commits into from

Commits on Jan 23, 2024

  1. fix bug that the min and max elem in function middleSplit_ is wrong s… 

    …ometimes.

if  span is always equal to max_span and equal to 0,if condition(span > (1 - EPS) * max_span) is always false, the  min_elem and max_elem are always the default initailized value 0, this is a bug. so the max_elem and min_elem should inlitialized while setting max_span.
This bug could be occur while there all the points which has the same location(x,y,z).
    @YongZouGN
    YongZouGN authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f153932 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from YongZouGN/YongZouGN-patch-1 

    fix bug that the min and max elem in  function middleSplit_ is  wrong sometimes.
    @YongZouGN
    YongZouGN authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e216bbc View commit details
    Browse the repository at this point in the history