Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging main into dev17.0 #1

Closed
wants to merge 1,275 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
1275 commits
Select commit Hold shift + click to select a range
5e168b0
Update dependencies from https://github.com/dotnet/arcade build 20201…
dotnet-maestro[bot] Dec 18, 2020
daee186
Convert AdditionalProjects to a ProjectCollection
sharwell Dec 18, 2020
31775ff
Improve code sharing for tests
sharwell Dec 21, 2020
0da6019
Share code for highlighting braces in tests
sharwell Dec 22, 2020
3acaa13
Update dependencies from https://github.com/dotnet/arcade build 20201…
dotnet-maestro[bot] Dec 22, 2020
247623f
Support markup diagnostics in additional projects
sharwell Dec 22, 2020
26513a9
Remove duplicate parameters from calls
sharwell Dec 22, 2020
5d3e5ee
Simplify implementation using immutable evaluated model
sharwell Dec 22, 2020
9cf7eae
Pass all source files using EvaluatedProjectState
sharwell Dec 22, 2020
48aa5a3
Add file header template
sharwell Dec 22, 2020
bc230aa
Update Roslyn 3 testing to support C# 9
sharwell Dec 23, 2020
f20d80e
Fix inheritance of ReferenceAssemblies, OutputKind, and Documentation…
sharwell Dec 23, 2020
d783311
Add regression test for markup splitting line end
sharwell Dec 23, 2020
904d69e
Update dependencies from https://github.com/dotnet/arcade build 20201…
dotnet-maestro[bot] Dec 23, 2020
2ea3a68
Fix spelling errors for 'visualizer'
sharwell Dec 23, 2020
873790b
Migrate from MSBuild.Sdk.Extras to Microsoft.NET.Sdk.WindowsDesktop
sharwell Dec 23, 2020
a87ef95
Merge pull request #681 from sharwell/file-header-template
sharwell Dec 23, 2020
04a59f8
Merge pull request #683 from sharwell/verify-markup
sharwell Dec 23, 2020
93af843
Merge pull request #685 from sharwell/visualizer-typo
sharwell Dec 23, 2020
0e6a64a
Merge pull request #686 from sharwell/desktop-build
sharwell Dec 23, 2020
2bf7c28
Merge pull request #680 from sharwell/more-projects
sharwell Dec 23, 2020
fea6b64
Update dependencies from https://github.com/dotnet/arcade build 20201…
dotnet-maestro[bot] Dec 29, 2020
4955ce3
Update the reference assemblies for net5.0 to RTM
sharwell Dec 30, 2020
c03d319
Merge pull request #688 from sharwell/net50-rtm
sharwell Dec 30, 2020
e4f64e4
Update dependencies from https://github.com/dotnet/arcade build 20201…
dotnet-maestro[bot] Dec 31, 2020
43f2f3d
Add SourceGenerators (VB) examples.
DualBrain Jan 6, 2021
1cc0cab
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jan 9, 2021
c17587b
Add projects for supporting source generator testing
sharwell Jan 12, 2021
c0a78d2
Fix validation of diagnostics in source generator tests
sharwell Jan 13, 2021
90c7987
Remove unusable verifier methods
sharwell Jan 13, 2021
dd1a3f3
Port check-ins for Maths generator from old PR
lucabol Jan 14, 2021
f50de95
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jan 14, 2021
4b93c45
Merge pull request #695 from lucabol/master
jmarolf Jan 14, 2021
6f9cf96
[master] Update dependencies from dotnet/arcade (#701)
dotnet-maestro[bot] Jan 21, 2021
739c94e
Merge remote-tracking branch 'dotnet/master' into nuget-config-refere…
sharwell Jan 21, 2021
3046d1d
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jan 23, 2021
1b1b5ee
Merge pull request #694 from sharwell/test-generators
sharwell Jan 26, 2021
51a5de8
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jan 26, 2021
1b6f5bb
Merge pull request #639 from KatoStoelen/nuget-config-referenceassemb…
sharwell Jan 26, 2021
39aa253
update version of the roslyn packages (and their dependencies)
jmarolf Jan 26, 2021
60afadd
add non-nullable references support
jmarolf Jan 26, 2021
52acf72
annotate syntax visualizer
jmarolf Jan 26, 2021
a9d6001
move common properties to build.props
jmarolf Jan 27, 2021
737e874
update LangVersion
jmarolf Jan 27, 2021
270e853
small fixes
jmarolf Jan 27, 2021
8b2477e
fix integration project
jmarolf Jan 27, 2021
a6d07e8
Update src/Directory.Build.props
jmarolf Jan 27, 2021
f13f68c
Update src/VisualStudio.Roslyn.SDK/SyntaxVisualizer/Roslyn.SyntaxVisu…
jmarolf Jan 27, 2021
efd6ba5
Update src/VisualStudio.Roslyn.SDK/SyntaxVisualizer/Roslyn.SyntaxVisu…
jmarolf Jan 27, 2021
36faeda
don't use Microsoft.VisualStudio.SDK
jmarolf Jan 27, 2021
c1a428a
update Microsoft.VisualStudio.Validation version
jmarolf Jan 28, 2021
9a8c9af
update editorconfig to include settings for spaces
jmarolf Jan 28, 2021
c977ccb
use pattern matching
jmarolf Jan 28, 2021
addd56e
Merge pull request #709 from jmarolf/bugfix/visualizer-crash
jmarolf Jan 28, 2021
3b0ce24
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jan 28, 2021
d6b3c6c
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jan 30, 2021
dd5330b
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Feb 2, 2021
5af59d5
Use MSBuildProjectFile
Youssef1313 Feb 2, 2021
c9a3ca8
Use MSBuildProjectFile
Youssef1313 Feb 2, 2021
cbd4dbd
Fixup feeds
mmitche Feb 2, 2021
92f5504
Merge pull request #720 from Youssef1313/patch-1
sharwell Feb 3, 2021
556b585
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Feb 3, 2021
ca6d613
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Feb 6, 2021
bf45296
Merge pull request #670 from cristianosuzuki77/master
JoeRobich Feb 8, 2021
db2d280
Clean up nuget feeds
JoeRobich Feb 8, 2021
ad192a2
Merge pull request #723 from dotnet/fix-feeds
JoeRobich Feb 8, 2021
6cccc74
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Feb 9, 2021
6684478
Merge pull request #725 from dotnet/feed-update-master
JoeRobich Feb 9, 2021
ce5ccd6
Add component debugger
chsienki Feb 9, 2021
e4641bf
Move to SetScale build pool
JoeRobich Feb 11, 2021
9792263
Pass access token when uploading insertion files
JoeRobich Feb 11, 2021
800be6d
Merge pull request #727 from dotnet/move-to-sspool
JoeRobich Feb 11, 2021
b079869
PR Feedback
chsienki Feb 12, 2021
5ef7fee
Address PROTOTYPE: comments:
chsienki Feb 16, 2021
f2ddb61
Add package source
chsienki Feb 16, 2021
c86f8bd
Use async lazy to get compiler root from the UI thread
chsienki Feb 16, 2021
92e3b89
NuGoop
chsienki Feb 16, 2021
ffd65a0
Add cap provider for VB
chsienki Feb 16, 2021
f78a1b7
Make capability provider dataflow based
chsienki Feb 17, 2021
492c07c
Don't warn on downgrade
chsienki Feb 17, 2021
65f8b41
cries in nuget
chsienki Feb 17, 2021
2af0f11
nuget harder
chsienki Feb 17, 2021
4dcffa0
Nuget 4.0
chsienki Feb 17, 2021
eb99474
Merge pull request #726 from chsienki/ComponentDebugger
jmarolf Feb 17, 2021
2ee7b3f
Revert "Add component debugger"
jmarolf Feb 17, 2021
0abb588
Merge pull request #732 from dotnet/revert-726-ComponentDebugger
jmarolf Feb 17, 2021
4683648
Support .exe and .winmd assembly extensions
sharwell Feb 23, 2021
ae9b783
Add CodeRefactoringProvider and SourceGenerator test packages to README
sharwell Feb 23, 2021
cc4f088
Merge pull request #737 from sharwell/update-readme
sharwell Feb 23, 2021
60dd4a1
Add support for .editorconfig documents
sharwell Feb 23, 2021
c69d641
Merge pull request #735 from sharwell/winmd
sharwell Feb 23, 2021
425dcad
Merge pull request #734 from sharwell/analyzer-config
sharwell Feb 23, 2021
22a55bf
Samples updates (#739)
chsienki Feb 25, 2021
15a6158
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Feb 26, 2021
ae7201e
Update MakeConstCodeFixProvider.cs
Youssef1313 Mar 2, 2021
86adecf
Update MakeConstCodeFixProvider.vb
Youssef1313 Mar 2, 2021
ec55905
Update samples/VisualBasic/MakeConst/MakeConst/MakeConstCodeFixProvid…
Youssef1313 Mar 2, 2021
23cf647
Fix build
Youssef1313 Mar 2, 2021
6a29f33
Add main to trigger list
allisonchou Mar 4, 2021
9edaa1e
Merge pull request #746 from dotnet/dev/allichou/add-main-trigger
allisonchou Mar 5, 2021
0092458
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Mar 5, 2021
ceed1c5
Change occurrences of master to main (#747)
allisonchou Mar 5, 2021
ddd0789
Remove the arity suffix from template items
sharwell Mar 5, 2021
05749cb
Component debugger (#738)
chsienki Mar 8, 2021
50e2a55
Merge pull request #749 from sharwell/shorter-names
sharwell Mar 8, 2021
67c220e
Fix TestXmlReferenceResolver semantics for missing files
sharwell Mar 8, 2021
cc8f8b4
Fix build errors in Roslyn.ComponentDebugger
sharwell Mar 9, 2021
94f2c41
Merge pull request #755 from sharwell/fix-build
sharwell Mar 9, 2021
85ffbc0
Merge pull request #751 from sharwell/missing-resolve
sharwell Mar 9, 2021
2e00b07
Allow adding source generator outputs by type
sharwell Mar 9, 2021
78d4055
Remove non-empty input requirement
sharwell Mar 9, 2021
01f1c94
Merge pull request #758 from sharwell/generated-sources
sharwell Mar 10, 2021
ef87003
[main] Update dependencies from dotnet/arcade (#753)
dotnet-maestro[bot] Mar 11, 2021
8491f47
Add ProjectState.GeneratedSources API
sharwell Mar 11, 2021
63af4f9
Allow running tests with no enabled analyzers
sharwell Mar 11, 2021
8b63f3d
Avoid requiring custom TestBehaviors for source generator tests
sharwell Mar 11, 2021
1e28e66
Simplify source generator testing
sharwell Mar 11, 2021
e0c5578
Add TestBehaviors.SkipGeneratedSourcesCheck
sharwell Mar 11, 2021
ea51db4
Merge pull request #759 from sharwell/generated-sources
sharwell Mar 11, 2021
7bd1821
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Mar 12, 2021
26043a2
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Mar 15, 2021
c4346f0
Mark analyzer packages as development dependencies
sharwell Mar 16, 2021
ae252a8
Merge pull request #764 from sharwell/dev-dependency
sharwell Mar 16, 2021
a7dc831
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Mar 17, 2021
6797781
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Mar 18, 2021
59369df
Restore .cs file for options control (#768)
chsienki Mar 22, 2021
b7dbfcd
[main] Update dependencies from dotnet/arcade (#769)
dotnet-maestro[bot] Mar 26, 2021
16f6383
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Mar 27, 2021
783d655
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Mar 30, 2021
07938cd
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 1, 2021
33aaf1d
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 2, 2021
619f270
Update to Microsoft.CodeAnalysis 3.9.0
sharwell Apr 2, 2021
4a33078
Improve error messages for mismatched encodings
sharwell Apr 2, 2021
aedc893
Fix failure to validate compiler errors in generated sources
sharwell Apr 2, 2021
ac6461c
Merge pull request #776 from sharwell/detect-warnings
sharwell Apr 2, 2021
de6ec52
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 3, 2021
ee21916
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 6, 2021
d16bce9
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 8, 2021
d4611dd
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 9, 2021
730cd67
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 10, 2021
521b7cd
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 13, 2021
1751151
Merge pull request #783 from dotnet/merges/main-to-dev17.0
genlu Apr 14, 2021
2095c55
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 15, 2021
ec52905
Use merged interops
genlu Apr 16, 2021
82bac53
Merge pull request #787 from genlu/UpdateInterops
jmarolf Apr 16, 2021
b85f563
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 16, 2021
ebeb388
Authentication for intenral nuget feed
genlu Apr 16, 2021
e840f95
Merge pull request #789 from genlu/UpdateInterops
genlu Apr 16, 2021
521b387
dev17 setup
genlu Apr 16, 2021
1db13f2
Merge pull request #790 from genlu/setup
genlu Apr 16, 2021
2786054
Version bump for dev17
genlu Apr 16, 2021
8835cb7
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 17, 2021
38459e5
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 20, 2021
ca6e48c
Use signed packages and remove internal feed
genlu Apr 20, 2021
806b715
Merge pull request #791 from dotnet/genlu-patch-1
genlu Apr 20, 2021
70281c9
Merge pull request #796 from genlu/usePublicPackages
genlu Apr 20, 2021
6370c83
Fix
genlu Apr 20, 2021
3d66ed6
Merge pull request #797 from genlu/usePublicPackages
genlu Apr 20, 2021
dc0e983
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 21, 2021
34274ee
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 22, 2021
8a1306b
Add OneLocBuild
jonfortescue Apr 23, 2021
4b27141
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 24, 2021
abe4a2b
Change to reflect CI
jonfortescue Apr 26, 2021
ff639f7
Add package
jonfortescue Apr 27, 2021
b3b0e1d
Merge pull request #802 from dotnet/loc-testing
jmarolf Apr 28, 2021
e5e1324
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 29, 2021
53ba88d
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Apr 30, 2021
15974e4
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 1, 2021
fefb059
Dispose workspaces at the end of RunAsync
sharwell May 3, 2021
e8447d9
Merge pull request #809 from sharwell/dispose-workspace
sharwell May 3, 2021
91d1b98
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 4, 2021
a3c7fce
[main] Update dependencies from dotnet/arcade (#811)
dotnet-maestro[bot] May 6, 2021
29200c8
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 7, 2021
29678a6
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 8, 2021
971455b
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 11, 2021
4021ff0
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 12, 2021
f6b75d8
Enable Arcade v3 publishing
JoeRobich May 12, 2021
0015f73
Turn on OneLocBuild PRs (#816)
jonfortescue May 12, 2021
80058dc
Merge pull request #818 from dotnet/v3-publishing
JoeRobich May 12, 2021
8d98772
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 13, 2021
31b3fe1
dev17 reference version bump
genlu May 13, 2021
7bae258
Merge pull request #820 from genlu/dev17fix
genlu May 13, 2021
f092fff
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 14, 2021
90c8e02
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 15, 2021
addfc3d
Update VS SDK
genlu May 19, 2021
2a50647
Merge pull request #824 from genlu/vssdk
genlu May 19, 2021
c539722
update versions in preparation for release
jmarolf May 19, 2021
d9e9d3d
Merge pull request #826 from jmarolf/update-version-number-to-prepare…
jmarolf May 20, 2021
9f3f98a
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 22, 2021
3b02486
Merge pull request #692 from DualBrain/master
jmarolf May 24, 2021
6d4d0ae
add vb generator samples to the samples solution
jmarolf May 24, 2021
dfa1b4a
fix symbol comparison
jmarolf May 24, 2021
c969e66
fix formatting
jmarolf May 24, 2021
54991d5
explicitly cast
jmarolf May 24, 2021
fc346e8
rename projects to distinguish language
jmarolf May 24, 2021
2136e57
use correct dependencies
jmarolf May 24, 2021
852a738
Always publish build logs.
JoeRobich May 24, 2021
9cf8ddd
use latest apis
jmarolf May 25, 2021
3fb02cc
do not increment solution version number
jmarolf May 25, 2021
e5caae4
Merge pull request #831 from dotnet/dev/jorobich/always-publish-logs
JoeRobich May 25, 2021
a60d313
remove vb mustache generator
jmarolf May 25, 2021
074c879
repack nuget packages for shipping
jmarolf May 25, 2021
662f541
Merge pull request #833 from jmarolf/use-nuget-repack-tool
jmarolf May 25, 2021
02a5cc4
Use verion.props for component debugger project
chsienki May 25, 2021
6da4207
Unify nuget references and remove warning suppression
chsienki May 25, 2021
9539ad9
Dte8 version
chsienki May 25, 2021
febc3b5
lots more nuget updates
chsienki May 26, 2021
e06be22
[main] Update dependencies from dotnet/arcade (#832)
dotnet-maestro[bot] May 26, 2021
856b8ed
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 27, 2021
af14381
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 28, 2021
d7d61eb
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] May 30, 2021
444f049
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jun 1, 2021
d48a157
remove call in Main
jmarolf Jun 1, 2021
3b73f78
Merge pull request #830 from jmarolf/update-samples-solution
jmarolf Jun 1, 2021
d542fb7
fix SourceGenerators.sln project references
ZacharyPatten Jun 3, 2021
3a91622
Merge pull request #851 from ZacharyPatten/main
jmarolf Jun 3, 2021
93f58ae
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jun 3, 2021
a9ea478
using nuget,org versions of test framework
jmarolf Jun 3, 2021
331646d
Merge pull request #855 from jmarolf/use-nuget-version-in-templates
jmarolf Jun 3, 2021
8652089
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jun 4, 2021
9b100e8
Update dependencies from https://github.com/dotnet/arcade build 20210…
dotnet-maestro[bot] Jun 5, 2021
38150ef
Merge pull request #835 from chsienki/use_versionprops_for_debugger
jmarolf Jun 15, 2021
876f52e
Fix support for multiple languages in AdditionalProjects
sharwell Jun 21, 2021
815b377
Improve triggering and validation for multi-project scenarios
sharwell Jun 21, 2021
c7a8347
Track projects where diagnostics are reported
sharwell Jun 22, 2021
0f5e185
Support TrySelectDiagnosticToFix for Fix All operations
sharwell Jun 22, 2021
10b52de
Merge pull request #870 from sharwell/additional-languages
sharwell Jun 22, 2021
db69a5b
Merge pull request #871 from sharwell/fix-all-selector
sharwell Jun 22, 2021
097cf21
Merge pull request #785 from dotnet/merges/main-to-dev17.0
JoeRobich Jun 22, 2021
b5e8451
Only require code fix for first iteration
sharwell Jun 23, 2021
70dbc0e
Merge pull request #875 from sharwell/first-iteration
sharwell Jun 23, 2021
c300880
Show differences when only end-of-line changes
sharwell Jun 28, 2021
eb3bce0
Merge pull request #878 from sharwell/show-eol
sharwell Jun 29, 2021
5b0208c
update versions to 1.1.1
jmarolf Jul 1, 2021
6334343
Merge pull request #879 from dotnet/update-versions
jmarolf Jul 1, 2021
de9af89
Add ReferenceAssemblies.Net.Net60
sharwell Jul 21, 2021
b7df823
Merge pull request #883 from sharwell/net60
sharwell Jul 22, 2021
709bfd4
Added closing slash to analyzer reference XML
RichardMelito Aug 4, 2021
6a80dc4
Merge pull request #885 from RichardMelito/main
sharwell Aug 4, 2021
6d70e6e
Update to DiffPlex 1.5.0
sharwell Aug 13, 2021
e5420e2
Merge pull request #886 from sharwell/diffplex
sharwell Aug 13, 2021
35a163b
Update component debugger to work for VS 2022 (#896)
chsienki Sep 16, 2021
4d5deb6
update yaml
jmarolf Sep 17, 2021
0e0f3de
Merge pull request #898 from jmarolf/update-yaml
jmarolf Sep 17, 2021
57470e3
Merge remote-tracking branch 'upstream/main' into merges/main-to-dev17.0
jmarolf Sep 17, 2021
eec909e
Merge pull request #872 from dotnet/merges/main-to-dev17.0
jmarolf Sep 17, 2021
0d10cdc
Add down level version of MS.CA for generators
chsienki Sep 17, 2021
3e776c4
Merge pull request #899 from dotnet/generator_version
jmarolf Sep 17, 2021
249b184
Merge pull request #743 from Youssef1313/patch-1
jmarolf Sep 17, 2021
7ff36db
Merge remote-tracking branch 'upstream/main' into dev17.0
jmarolf Sep 17, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -179,7 +179,7 @@ public virtual async Task RunAsync(CancellationToken cancellationToken = default
var fixableDiagnostics = ImmutableArray<string>.Empty;
var testState = TestState.WithInheritedValuesApplied(null, fixableDiagnostics).WithProcessedMarkup(MarkupOptions, defaultDiagnostic, supportedDiagnostics, fixableDiagnostics, DefaultFilePath);

await VerifyDiagnosticsAsync(testState.Sources.ToArray(), testState.AdditionalFiles.ToArray(), testState, testState.AdditionalProjects.Values.ToArray(), testState.AdditionalReferences.ToArray(), testState.ExpectedDiagnostics.ToArray(), Verify, cancellationToken).ConfigureAwait(false);
await VerifyDiagnosticsAsync(testState, testState.AdditionalProjects.Values.ToArray(), testState.ExpectedDiagnostics.ToArray(), Verify, cancellationToken).ConfigureAwait(false);
}

/// <summary>
@@ -233,25 +233,24 @@ protected string FormatVerifierMessage(ImmutableArray<DiagnosticAnalyzer> analyz
/// General method that gets a collection of actual <see cref="Diagnostic"/>s found in the source after the
/// analyzer is run, then verifies each of them.
/// </summary>
/// <param name="sources">An array of strings to create source documents from to run the analyzers on.</param>
/// <param name="additionalFiles">Additional documents to include in the project.</param>
/// <param name="primaryProject">The primary project.</param>
/// <param name="additionalProjects">Additional projects to include in the solution.</param>
/// <param name="additionalMetadataReferences">Additional metadata references to include in the project.</param>
/// <param name="expected">A collection of <see cref="DiagnosticResult"/>s that should appear after the analyzer
/// is run on the sources.</param>
/// <param name="verifier">The verifier to use for test assertions.</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> that the task will observe.</param>
/// <returns>A <see cref="Task"/> representing the asynchronous operation.</returns>
protected async Task VerifyDiagnosticsAsync((string filename, SourceText content)[] sources, (string filename, SourceText content)[] additionalFiles, ProjectState primaryProject, ProjectState[] additionalProjects, MetadataReference[] additionalMetadataReferences, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken)
protected async Task VerifyDiagnosticsAsync(ProjectState primaryProject, ProjectState[] additionalProjects, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken)
{
(string filename, SourceText content)[] sources = primaryProject.Sources.ToArray();

var analyzers = GetDiagnosticAnalyzers().ToImmutableArray();
VerifyDiagnosticResults(await GetSortedDiagnosticsAsync(sources, additionalFiles, primaryProject, additionalProjects, additionalMetadataReferences, analyzers, verifier, cancellationToken).ConfigureAwait(false), analyzers, expected, verifier);
await VerifyGeneratedCodeDiagnosticsAsync(analyzers, sources, additionalFiles, primaryProject, additionalProjects, additionalMetadataReferences, expected, verifier, cancellationToken).ConfigureAwait(false);
await VerifySuppressionDiagnosticsAsync(analyzers, sources, additionalFiles, primaryProject, additionalProjects, additionalMetadataReferences, expected, verifier, cancellationToken).ConfigureAwait(false);
VerifyDiagnosticResults(await GetSortedDiagnosticsAsync(sources, primaryProject, additionalProjects, analyzers, verifier, cancellationToken).ConfigureAwait(false), analyzers, expected, verifier);
await VerifyGeneratedCodeDiagnosticsAsync(analyzers, sources, primaryProject, additionalProjects, expected, verifier, cancellationToken).ConfigureAwait(false);
await VerifySuppressionDiagnosticsAsync(analyzers, sources, primaryProject, additionalProjects, expected, verifier, cancellationToken).ConfigureAwait(false);
}

private async Task VerifyGeneratedCodeDiagnosticsAsync(ImmutableArray<DiagnosticAnalyzer> analyzers, (string filename, SourceText content)[] sources, (string filename, SourceText content)[] additionalFiles, ProjectState primaryProject, ProjectState[] additionalProjects, MetadataReference[] additionalMetadataReferences, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken)
private async Task VerifyGeneratedCodeDiagnosticsAsync(ImmutableArray<DiagnosticAnalyzer> analyzers, (string filename, SourceText content)[] sources, ProjectState primaryProject, ProjectState[] additionalProjects, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken)
{
if (TestBehaviors.HasFlag(TestBehaviors.SkipGeneratedCodeCheck)
|| analyzers.All(analyzer => AnalyzerInfo.HasConfiguredGeneratedCodeAnalysis(analyzer)))
@@ -274,10 +273,10 @@ private async Task VerifyGeneratedCodeDiagnosticsAsync(ImmutableArray<Diagnostic

var generatedCodeVerifier = verifier.PushContext("Verifying exclusions in <auto-generated> code");
var commentPrefix = Language == LanguageNames.CSharp ? "//" : "'";
VerifyDiagnosticResults(await GetSortedDiagnosticsAsync(sources.Select(x => (x.filename, x.content.Replace(new TextSpan(0, 0), $" {commentPrefix} <auto-generated>\r\n"))).ToArray(), additionalFiles, primaryProject, additionalProjects, additionalMetadataReferences, analyzers, generatedCodeVerifier, cancellationToken).ConfigureAwait(false), analyzers, expectedResults, generatedCodeVerifier);
VerifyDiagnosticResults(await GetSortedDiagnosticsAsync(sources.Select(x => (x.filename, x.content.Replace(new TextSpan(0, 0), $" {commentPrefix} <auto-generated>\r\n"))).ToArray(), primaryProject, additionalProjects, analyzers, generatedCodeVerifier, cancellationToken).ConfigureAwait(false), analyzers, expectedResults, generatedCodeVerifier);
}

private async Task VerifySuppressionDiagnosticsAsync(ImmutableArray<DiagnosticAnalyzer> analyzers, (string filename, SourceText content)[] sources, (string filename, SourceText content)[] additionalFiles, ProjectState primaryProject, ProjectState[] additionalProjects, MetadataReference[] additionalMetadataReferences, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken)
private async Task VerifySuppressionDiagnosticsAsync(ImmutableArray<DiagnosticAnalyzer> analyzers, (string filename, SourceText content)[] sources, ProjectState primaryProject, ProjectState[] additionalProjects, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken)
{
if (TestBehaviors.HasFlag(TestBehaviors.SkipSuppressionCheck))
{
@@ -301,7 +300,7 @@ private async Task VerifySuppressionDiagnosticsAsync(ImmutableArray<DiagnosticAn
var suppressionVerifier = verifier.PushContext($"Verifying exclusions in '{prefix}' code");
var suppressedDiagnostics = expected.Where(x => IsSubjectToExclusion(x, sources)).Select(x => x.Id).Distinct();
var suppression = prefix + " " + string.Join(", ", suppressedDiagnostics);
VerifyDiagnosticResults(await GetSortedDiagnosticsAsync(sources.Select(x => (x.filename, x.content.Replace(new TextSpan(0, 0), $"{suppression}\r\n"))).ToArray(), additionalFiles, primaryProject, additionalProjects, additionalMetadataReferences, analyzers, suppressionVerifier, cancellationToken).ConfigureAwait(false), analyzers, expectedResults, suppressionVerifier);
VerifyDiagnosticResults(await GetSortedDiagnosticsAsync(sources.Select(x => (x.filename, x.content.Replace(new TextSpan(0, 0), $"{suppression}\r\n"))).ToArray(), primaryProject, additionalProjects, analyzers, suppressionVerifier, cancellationToken).ConfigureAwait(false), analyzers, expectedResults, suppressionVerifier);
}

/// <summary>
@@ -955,18 +954,16 @@ private static bool IsInSourceFile(DiagnosticResult result, (string filename, So
/// <see cref="Document"/>.
/// </summary>
/// <param name="sources">Classes in the form of strings.</param>
/// <param name="additionalFiles">Additional documents to include in the project.</param>
/// <param name="primaryProject">The primary project.</param>
/// <param name="additionalProjects">Additional projects to include in the solution.</param>
/// <param name="additionalMetadataReferences">Additional metadata references to include in the project.</param>
/// <param name="analyzers">The analyzers to be run on the sources.</param>
/// <param name="verifier">The verifier to use for test assertions.</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> that the task will observe.</param>
/// <returns>A collection of <see cref="Diagnostic"/>s that surfaced in the source code, sorted by
/// <see cref="Diagnostic.Location"/>.</returns>
private async Task<ImmutableArray<Diagnostic>> GetSortedDiagnosticsAsync((string filename, SourceText content)[] sources, (string filename, SourceText content)[] additionalFiles, ProjectState primaryProject, ProjectState[] additionalProjects, MetadataReference[] additionalMetadataReferences, ImmutableArray<DiagnosticAnalyzer> analyzers, IVerifier verifier, CancellationToken cancellationToken)
private async Task<ImmutableArray<Diagnostic>> GetSortedDiagnosticsAsync((string filename, SourceText content)[] sources, ProjectState primaryProject, ProjectState[] additionalProjects, ImmutableArray<DiagnosticAnalyzer> analyzers, IVerifier verifier, CancellationToken cancellationToken)
{
var solution = await GetSolutionAsync(sources, additionalFiles, primaryProject, additionalProjects, additionalMetadataReferences, verifier, cancellationToken);
var solution = await GetSolutionAsync(sources, primaryProject, additionalProjects, verifier, cancellationToken);
return await GetSortedDiagnosticsAsync(solution, analyzers, CompilerDiagnostics, cancellationToken);
}

@@ -1043,18 +1040,16 @@ protected virtual AnalyzerOptions GetAnalyzerOptions(Project project)
/// solution.
/// </summary>
/// <param name="sources">Classes in the form of strings.</param>
/// <param name="additionalFiles">Additional documents to include in the project.</param>
/// <param name="primaryProject">The primary project.</param>
/// <param name="additionalProjects">Additional projects to include in the solution.</param>
/// <param name="additionalMetadataReferences">Additional metadata references to include in the project.</param>
/// <param name="verifier">The verifier to use for test assertions.</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> that the task will observe.</param>
/// <returns>A solution containing a project with the specified sources and additional files.</returns>
private async Task<Solution> GetSolutionAsync((string filename, SourceText content)[] sources, (string filename, SourceText content)[] additionalFiles, ProjectState primaryProject, ProjectState[] additionalProjects, MetadataReference[] additionalMetadataReferences, IVerifier verifier, CancellationToken cancellationToken)
private async Task<Solution> GetSolutionAsync((string filename, SourceText content)[] sources, ProjectState primaryProject, ProjectState[] additionalProjects, IVerifier verifier, CancellationToken cancellationToken)
{
verifier.LanguageIsSupported(Language);

var project = await CreateProjectAsync(sources, additionalFiles, primaryProject, additionalProjects, additionalMetadataReferences, cancellationToken);
var project = await CreateProjectAsync(sources, primaryProject, additionalProjects, cancellationToken);
var documents = project.Documents.ToArray();

verifier.Equal(sources.Length, documents.Length, "Amount of sources did not match amount of Documents created");
@@ -1070,31 +1065,27 @@ private async Task<Solution> GetSolutionAsync((string filename, SourceText conte
/// applies compilation options to the project by calling <see cref="ApplyCompilationOptions"/>.</para>
/// </remarks>
/// <param name="sources">Classes in the form of strings.</param>
/// <param name="additionalFiles">Additional documents to include in the project.</param>
/// <param name="primaryProject">The primary project.</param>
/// <param name="additionalProjects">Additional projects to include in the solution.</param>
/// <param name="additionalMetadataReferences">Additional metadata references to include in the project.</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> that the task will observe.</param>
/// <returns>A <see cref="Project"/> created out of the <see cref="Document"/>s created from the source
/// strings.</returns>
protected async Task<Project> CreateProjectAsync((string filename, SourceText content)[] sources, (string filename, SourceText content)[] additionalFiles, ProjectState primaryProject, ProjectState[] additionalProjects, MetadataReference[] additionalMetadataReferences, CancellationToken cancellationToken)
protected async Task<Project> CreateProjectAsync((string filename, SourceText content)[] sources, ProjectState primaryProject, ProjectState[] additionalProjects, CancellationToken cancellationToken)
{
var project = await CreateProjectImplAsync(sources, additionalFiles, primaryProject, additionalProjects, additionalMetadataReferences, cancellationToken);
var project = await CreateProjectImplAsync(sources, primaryProject, additionalProjects, cancellationToken);
return ApplyCompilationOptions(project);
}

/// <summary>
/// Create a project using the input strings as sources.
/// </summary>
/// <param name="sources">Classes in the form of strings.</param>
/// <param name="additionalFiles">Additional documents to include in the project.</param>
/// <param name="primaryProject">The primary project.</param>
/// <param name="additionalProjects">Additional projects to include in the solution.</param>
/// <param name="additionalMetadataReferences">Additional metadata references to include in the project.</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> that the task will observe.</param>
/// <returns>A <see cref="Project"/> created out of the <see cref="Document"/>s created from the source
/// strings.</returns>
protected virtual async Task<Project> CreateProjectImplAsync((string filename, SourceText content)[] sources, (string filename, SourceText content)[] additionalFiles, ProjectState primaryProject, ProjectState[] additionalProjects, MetadataReference[] additionalMetadataReferences, CancellationToken cancellationToken)
protected virtual async Task<Project> CreateProjectImplAsync((string filename, SourceText content)[] sources, ProjectState primaryProject, ProjectState[] additionalProjects, CancellationToken cancellationToken)
{
var fileNamePrefix = DefaultFilePathPrefix;
var fileExt = DefaultFileExt;
@@ -1133,17 +1124,24 @@ protected virtual async Task<Project> CreateProjectImplAsync((string filename, S
.WithDocumentationMode(projectState.DocumentationMode));

var metadataReferences = await referenceAssemblies.ResolveAsync(projectState.Language, cancellationToken);
solution = solution.AddMetadataReferences(additionalProjectId, metadataReferences);
solution = solution.AddMetadataReferences(additionalProjectId, metadataReferences)
.AddMetadataReferences(additionalProjectId, projectState.AdditionalReferences);

for (var i = 0; i < projectState.Sources.Count; i++)
{
(var newFileName, var source) = projectState.Sources[i];
var documentId = DocumentId.CreateNewId(additionalProjectId, debugName: newFileName);
solution = solution.AddDocument(documentId, newFileName, source, filePath: newFileName);
}

foreach (var (newFileName, source) in projectState.AdditionalFiles)
{
var documentId = DocumentId.CreateNewId(additionalProjectId, debugName: newFileName);
solution = solution.AddAdditionalDocument(documentId, newFileName, source, filePath: newFileName);
}
}

solution = solution.AddMetadataReferences(projectId, additionalMetadataReferences);
solution = solution.AddMetadataReferences(projectId, primaryProject.AdditionalReferences);

for (var i = 0; i < sources.Length; i++)
{
@@ -1152,9 +1150,8 @@ protected virtual async Task<Project> CreateProjectImplAsync((string filename, S
solution = solution.AddDocument(documentId, newFileName, source, filePath: newFileName);
}

for (var i = 0; i < additionalFiles.Length; i++)
foreach (var (newFileName, source) in primaryProject.AdditionalFiles)
{
(var newFileName, var source) = additionalFiles[i];
var documentId = DocumentId.CreateNewId(projectId, debugName: newFileName);
solution = solution.AddAdditionalDocument(documentId, newFileName, source, filePath: newFileName);
}
Loading