Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare support for Python 3.10 #841

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Declare support for Python 3.10 #841

merged 1 commit into from
Nov 13, 2021

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 13, 2021

@jmcnamara jmcnamara merged commit f933e80 into jmcnamara:main Nov 13, 2021
@jmcnamara
Copy link
Owner

Thanks. Merged.

I'll add it to the test matrix as well.

@hugovk hugovk deleted the patch-1 branch November 13, 2021 10:19
@hugovk
Copy link
Contributor Author

hugovk commented Nov 13, 2021

It just so happens that 3.x currently points to 3.10 so it's already in the test matrix :)

I'd recommend testing against all supported versions, the tests run quickly enough. Also I'd suggest only supporting Python versions supported by the core team, currently 3.6+.

cycle latest release eol
3.10 3.10.0 2021-10-04 2026-10-04
3.9 3.9.8 2020-10-05 2025-10-05
3.8 3.8.12 2019-10-14 2024-10-14
3.7 3.7.12 2018-06-27 2023-06-27
3.6 3.6.15 2016-12-23 2021-12-23
3.5 3.5.10 2015-09-30 2020-09-13
3.4 3.4.10 2014-03-16 2019-03-18

jmcnamara added a commit that referenced this pull request Nov 13, 2021
@jmcnamara
Copy link
Owner

It just so happens that 3.x currently points to 3.10 so it's already in the test matrix :)

I was referring to my local test matrix (be8d1cb) but I should really (as you say) turn on the other versions in the GitHub actions testing. I had them on before but 99% of the time they are unnecessary for most people so I turned them off. I'll turn them on again.

Also I'd suggest only supporting Python versions supported by the core team, currently 3.6+.

Yeah. I'd like to (and probably will) drop 3.4 at least.

Anyway thanks for the prompt.

@hugovk
Copy link
Contributor Author

hugovk commented Nov 13, 2021

Please see PR #842 :)

@MartinPacker
Copy link

I think I would recommend 3.8+ - though this is obviously a moving window.

(3.8 has the Walrus Operator which I've found - in my md2pptx project - to yield benefits.)

"Recommend" is not the same as "require", of course.

@hugovk
Copy link
Contributor Author

hugovk commented Nov 14, 2021

Python 3.6 and 3.7 account for 61% of downloads: #842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants