-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 3.4 and 3.5 #842
Conversation
Removing 3.4 is as far as I want to go for now and I will probably remove it before the end of the year. |
Sure, updated to only drop 3.4. |
@@ -46,7 +46,7 @@ As a minimum, tests should be run using Python 3.5+. | |||
|
|||
I use [pythonbrew](https://github.com/utahta/pythonbrew) and [Tox](https://tox.readthedocs.io/en/latest/) to test with a variety of Python versions. See the Makefile for example test targets. A `tox.ini` file is already configured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self. Remove this line about tox after merge.
Kudos, SonarCloud Quality Gate passed! |
635e1d3
to
4d014cb
Compare
Kudos, SonarCloud Quality Gate passed! |
I've resolved the merge conflict.
I see https://github.com/jmcnamara/XlsxWriter/releases/tag/RELEASE_3.0.3 went out in February, any plans when to merge this? Thanks! Noting also that 3.6 is EOL since December. Updated stats:
Date range: 2022-03-01 - 2022-03-31 |
I do still plan to merge this. Probably in the next few weeks but in the next release either way. Thanks for keeping it rebased. |
Sorry for sitting on this for so long. Would it be much work for you to update it to drop 3.5 support at the same time? |
Kudos, SonarCloud Quality Gate passed! |
Updated! |
Merged. Thanks. |
Python 3.4 and 3.5 are EOL:
And little used. Here's the pip installs for XlsxWriter from PyPI for October 2021:
Source:
pip install -U pypistats && pypistats python_minor XlsxWriter --last-month
Let's test the supported versions on the CI to make sure the tests pass.
Also move slightly slower PyPy first, and replace deprecated
pypy3
(not available in newer images) with explicitpypy-3.8
.