Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 3.4 and 3.5 #842

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 13, 2021

Python 3.4 and 3.5 are EOL:

cycle latest release eol
3.10 3.10.0 2021-10-04 2026-10-04
3.9 3.9.8 2020-10-05 2025-10-05
3.8 3.8.12 2019-10-14 2024-10-14
3.7 3.7.12 2018-06-27 2023-06-27
3.6 3.6.15 2016-12-23 2021-12-23
3.5 3.5.10 2015-09-30 2020-09-13
3.4 3.4.10 2014-03-16 2019-03-18

And little used. Here's the pip installs for XlsxWriter from PyPI for October 2021:

category percent downloads
3.7 47.84% 3,781,268
3.8 26.41% 2,087,040
3.6 12.70% 1,003,885
3.9 6.30% 498,116
2.7 4.43% 350,129
null 1.39% 109,516
3.5 0.66% 51,784
3.10 0.22% 17,383
3.4 0.06% 4,750
3.11 0.00% 23
3.3 0.00% 6
Total 7,903,900

Source: pip install -U pypistats && pypistats python_minor XlsxWriter --last-month

Let's test the supported versions on the CI to make sure the tests pass.


Also move slightly slower PyPy first, and replace deprecated pypy3 (not available in newer images) with explicit pypy-3.8.

@jmcnamara
Copy link
Owner

Removing 3.4 is as far as I want to go for now and I will probably remove it before the end of the year.

@hugovk hugovk changed the title Drop support for EOL Python 3.4 and 3.5 Drop support for EOL Python 3.4 Nov 14, 2021
@hugovk
Copy link
Contributor Author

hugovk commented Nov 14, 2021

Sure, updated to only drop 3.4.

@@ -46,7 +46,7 @@ As a minimum, tests should be run using Python 3.5+.

I use [pythonbrew](https://github.com/utahta/pythonbrew) and [Tox](https://tox.readthedocs.io/en/latest/) to test with a variety of Python versions. See the Makefile for example test targets. A `tox.ini` file is already configured.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self. Remove this line about tox after merge.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmcnamara jmcnamara force-pushed the main branch 4 times, most recently from 635e1d3 to 4d014cb Compare January 22, 2022 10:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hugovk
Copy link
Contributor Author

hugovk commented Apr 28, 2022

I've resolved the merge conflict.


Removing 3.4 is as far as I want to go for now and I will probably remove it before the end of the year.

I see https://github.com/jmcnamara/XlsxWriter/releases/tag/RELEASE_3.0.3 went out in February, any plans when to merge this? Thanks!


Noting also that 3.6 is EOL since December. Updated stats:

category percent downloads
3.7 38.34% 3,551,208
3.8 33.75% 3,125,834
3.6 14.13% 1,308,958
3.9 7.53% 697,756
2.7 3.09% 286,060
null 1.70% 157,453
3.10 1.06% 97,811
3.5 0.34% 31,784
3.4 0.05% 4,866
3.11 0.00% 73
3.3 0.00% 4
3.2 0.00% 1
Total 9,261,808

Date range: 2022-03-01 - 2022-03-31

@jmcnamara
Copy link
Owner

I see https://github.com/jmcnamara/XlsxWriter/releases/tag/RELEASE_3.0.3 went out in February, any plans when to merge this?

I do still plan to merge this. Probably in the next few weeks but in the next release either way. Thanks for keeping it rebased.

@jmcnamara
Copy link
Owner

Sorry for sitting on this for so long. Would it be much work for you to update it to drop 3.5 support at the same time?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hugovk
Copy link
Contributor Author

hugovk commented Aug 12, 2022

Updated!

@hugovk hugovk changed the title Drop support for EOL Python 3.4 Drop support for EOL Python 3.4 and 3.5 Aug 12, 2022
@jmcnamara jmcnamara merged commit 80da67c into jmcnamara:main Aug 12, 2022
@jmcnamara
Copy link
Owner

Merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants