Skip to content

Commit

Permalink
fix: pass proper env var to tracetesting Dockerfile (open-telemetry#1283
Browse files Browse the repository at this point in the history
)

* fix: pass proper env var to tracetesting Dockerfile

* chore: update changelog

* chore: update changelog
  • Loading branch information
jorgeepc authored Dec 6, 2023
1 parent b296ff3 commit a147f19
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ release.
([#1266](https://github.com/open-telemetry/opentelemetry-demo/pull/1266))
* [accountingservice] Add additional attributes to Kafka spans
([#1286](https://github.com/open-telemetry/opentelemetry-demo/pull/1286))
* fix env var for pinning trace-based test tool version
([#1283](https://github.com/open-telemetry/opentelemetry-demo/pull/1283))

## 1.6.0

Expand Down
2 changes: 2 additions & 0 deletions docker-compose.minimal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,8 @@ services:
build:
context: ./
dockerfile: ./test/tracetesting/Dockerfile
args:
- TRACETEST_IMAGE_VERSION
environment:
- AD_SERVICE_ADDR
- CART_SERVICE_ADDR
Expand Down
2 changes: 2 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,8 @@ services:
build:
context: ./
dockerfile: ./test/tracetesting/Dockerfile
args:
- TRACETEST_IMAGE_VERSION
environment:
- AD_SERVICE_ADDR
- CART_SERVICE_ADDR
Expand Down
2 changes: 2 additions & 0 deletions test/tracetesting/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ FROM alpine

WORKDIR /app

ARG TRACETEST_IMAGE_VERSION

RUN apk --update add bash jq curl
RUN curl -L https://raw.githubusercontent.com/kubeshop/tracetest/main/install-cli.sh | bash -s -- ${TRACETEST_IMAGE_VERSION}

Expand Down

0 comments on commit a147f19

Please sign in to comment.