Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass proper env var to tracetesting Dockerfile #1283

Merged
merged 4 commits into from
Dec 6, 2023
Merged

fix: pass proper env var to tracetesting Dockerfile #1283

merged 4 commits into from
Dec 6, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Nov 29, 2023 •
edited
Loading

Changes

This PR fixes the CLI version in test/tracetesting/Dockerfile to use the env variable that was added as part of #1239. This guarantees the use of the same image version for the tracetest server and CLI in the trace-based process.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@danielbdias
Copy link
Contributor

hi @julianocosta89 and @mviitane ! talking with Tracetest team, we believe that this issue caused some of the problems that you had on #1273.

@jorgeepc can you add an entry on the CHANGELOG with this change?

@jorgeepc jorgeepc marked this pull request as ready for review November 30, 2023 14:34
@jorgeepc jorgeepc requested a review from a team November 30, 2023 14:34
puckpuck
puckpuck approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit about the order of changelog entries, but otherwise LGTM.

CHANGELOG.md Outdated Show resolved Hide resolved
@puckpuck puckpuck merged commit 3547beb into open-telemetry:main Dec 6, 2023
27 checks passed
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@jorgeepc
fix: pass proper env var to tracetesting Dockerfile (open-telemetry#1283
a147f19 
)

* fix: pass proper env var to tracetesting Dockerfile

* chore: update changelog

* chore: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puckpuck puckpuck puckpuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeepc @danielbdias @puckpuck