Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent version of rust (I am not sure exactly which) added a check to ensure that all features used in the crate are defined in the
Cargo.toml
. This caused an error / warning for me because I am using a feature not named in theCargo.toml
called "disabled" to remove certain unfinished, long-running, or inaccurate tests (that I don't want to fully remove) from the compiled test harness.Previously I was doing this by broadly disabling the
unexpected_cfg
check entirely for the crate using:#![allow(unexpected_cfgs)]
With updates included in nightly there is a better solution to this. Which is to inform the compiler of any used, but undeclared features so that any that would be unexpected must be intentional. And the check can catch unintentional unused cfgs for you.
thanks to @Urgau for pointing this out in #38