Configuring Unexpected cfgs

crates/o5/Cargo.toml

@@ -25,3 +25,9 @@ anyhow = "1.0"
 # o5 pqc test
 # pqc_kyber = {version="0.7.1", features=["kyber1024", "std"]}
 ml-kem = "0.1.0"
+
+[lints.rust]
+# unexpected_cfgs are used to disable incomplete / WIP features and tests. This is
+# not an error for this library. This turns off that specific lint for the "disable" feature.
+unexpected_cfgs = { level = "allow", check-cfg = ['cfg(target_features, values("disabled"))'] }
+

crates/o5/src/lib.rs

@@ -1,7 +1,5 @@
 #![doc = include_str!("../README.md")]
-// unexpected_cfgs are used to disable incomplete / WIP features and tests. This is
-// not an error for this library.
-#![allow(unexpected_cfgs)]
+
 
 mod framing;
 // mod handshake;

crates/obfs4/Cargo.toml

@@ -89,3 +89,8 @@ tor-basic-utils = "0.20.0"
 # pqc_kyber = {version="0.7.1", features=["kyber1024", "std"]}
 # ml-kem = "0.1.0"
 
+[lints.rust]
+# unexpected_cfgs are used to disable incomplete / WIP features and tests. This is
+# not an error for this library. This turns off that specific lint for the "disable" feature.
+unexpected_cfgs = { level = "allow", check-cfg = ['cfg(target_features, values("disabled"))'] }
+

crates/obfs4/src/common/x25519_elligator2.rs

@@ -362,13 +362,15 @@ mod test {
 
     #[test]
     fn off_subgroup_check_edw() {
+        let mut count = 0;
+        let n_trials = 100;
         let mut rng = rand::thread_rng();
-        for _ in 0..100 {
+        for _ in 0..n_trials {
             let (repr, pk) = generate(&mut rng);
 
             // check if the generated public key is off the subgroup
             let v = scalar_mult_order(&pk);
-            let pk_off = !v.is_identity();
+            let _pk_off = !v.is_identity();
 
             // ----
 
@@ -390,7 +392,12 @@ mod test {
             let v = scalar_mult_order(&pk_254);
             let off_254 = !v.is_identity();
 
-            println!("pk_gen: {pk_off}, pk_255: {off_255}, pk_254: {off_254}");
+            // println!("pk_gen: {pk_off}, pk_255: {off_255}, pk_254: {off_254}");
+            if off_254 && off_255 {
+                count += 1;
+            }
         }
+        assert!(count > 0);
+        assert!(count < n_trials);
     }
 }

crates/obfs4/src/lib.rs

@@ -1,12 +1,4 @@
 #![doc = include_str!("../README.md")]
-// unexpected_cfgs are used to disable incomplete / WIP features and tests. This is
-// not an error for this library.
-#![allow(unexpected_cfgs)]
-
-// #![feature(trait_alias)]
-
-// #![allow(dead_code)]
-// #![allow(warnings)]
 
 pub mod client;
 pub mod common;