per-request headers discard default headers

[amirabiri]

In the following example:

class Lala
    include HTTParty
    headers 'Accept' => 'application/json'
end

Lala.post "/lala", :body => ..., :headers => { 'Content-Type' => 'application/special' }

The expected behavior is that the specific headers given for this particular request be merged with the default ones, so the final headers should be:

Accept:       application/json
Content-Type: application/special

However because of the first line in HTTParty.perform_request:

def perform_request(http_method, path, options, &block) #:nodoc:
    options = default_options.dup.merge(options)
    ...

The default headers are overwritten. This is due to the fact that merge isn't recursive - if the same key exists in both hashes it is overwritten. To merge in a different manner one must supply a block to handle conflicting keys.

I think in the specific case of :headers HTTParty should perform a deep merge.

[jnunemaker]

Yeah that makes sense. Happy to pull anything with good tests.

[amirabiri]

Sorry - I won't have time for that. I'm primarily a Java & C# developer and Rails is a secondary skill. I'm not familiar enough with Cucumber. It would have been a good learning experience for me, but I'm a bit swamped at the moment!

I can give you the patch for the line itself if that helps, but that a simpler one-liner which I'm sure you can do better than me anyway... :)