Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.start_archive does not send auth credentials #60

Closed
rukumam opened this issue Jun 10, 2014 · 2 comments
Closed

client.start_archive does not send auth credentials #60

rukumam opened this issue Jun 10, 2014 · 2 comments
Labels

Comments

@rukumam
Copy link

rukumam commented Jun 10, 2014

client.rb:34 overrides the headers to pass in the content-type. This causes only the content type to be included in the call, and the instance X-TB-PARTNER-AUTH and User-Agent headers are not included. This causes an authentication error to be returned. Changing line 34 as below fixes the issue.

:headers => self.class.headers.merge({"Content-Type" => "application/json" })

@aoberoi
Copy link
Contributor

aoberoi commented Jun 12, 2014

while i could fix this in our project, i'm wondering if this is an issue upstream in one of the libraries we use like httparty in your environment (e.g. windows).

the expected functionality of the code as is should be that the headers are merged, not overwritten. in fact, we've tested for this in the specs when we match against this cassette.

can you give us a little more detail about your environment (version of the OS, version of Ruby, versions of any other relevant packages)? i'm happy to fix this here but if we can help improve the upstream libraries too that would be a win for everyone.

@rukumam
Copy link
Author

rukumam commented Jun 14, 2014

@aoberoi, your hunch was right. This is a bug in httparty that was reported here: jnunemaker/httparty#255 and fixed in version 0.13.1 (I was on 0.12.0). Maybe the dependency in the opentok gemspec just needs to be updated to require at least this new version of httparty.

smudge added a commit to smudge/Opentok-Ruby-SDK that referenced this issue Jun 20, 2014
@aoberoi aoberoi added the bug label Sep 23, 2014
aoberoi added a commit that referenced this issue Sep 23, 2014
bump httparty version, fixes #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants