Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to joblib 1.3.0 #48

Merged
merged 7 commits into from
Jul 3, 2023

Conversation

thinkall
Copy link
Contributor

@thinkall thinkall commented Jun 29, 2023

joblib is upgraded to 1.3.0 and SafeFunction is removed, which results in below error:

>   from joblib._parallel_backends import SafeFunction
E   ImportError: cannot import name 'SafeFunction' from 'joblib._parallel_backends' (/opt/Python/3.10.12/x64/lib/python3.10/site-packages/joblib/_parallel_backends.py)

With this PR, joblib-spark will support joblib>=0.14 as before.

Closes #49

thinkall added a commit to thinkall/FLAML that referenced this pull request Jun 29, 2023
github-merge-queue bot pushed a commit to microsoft/FLAML that referenced this pull request Jun 30, 2023
* temp solution for joblib 1.3.0 issue, no need once joblib/joblib-spark#48 is merged

* update option
github-merge-queue bot pushed a commit to microsoft/FLAML that referenced this pull request Jun 30, 2023
* temp solution for joblib 1.3.0 issue, no need once joblib/joblib-spark#48 is merged

* update option
github-merge-queue bot pushed a commit to microsoft/FLAML that referenced this pull request Jun 30, 2023
* temp solution for joblib 1.3.0 issue, no need once joblib/joblib-spark#48 is merged

* update option
github-merge-queue bot pushed a commit to microsoft/FLAML that referenced this pull request Jun 30, 2023
* temp solution for joblib 1.3.0 issue, no need once joblib/joblib-spark#48 is merged

* update option
Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one comment.

@WeichenXu123 WeichenXu123 merged commit e5a797f into joblib:master Jul 3, 2023
@thinkall thinkall deleted the support_joblib_1.3.0 branch July 5, 2023 23:59
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* temp solution for joblib 1.3.0 issue, no need once joblib/joblib-spark#48 is merged

* update option
thinkall added a commit to microsoft/FLAML that referenced this pull request Sep 21, 2024
Fix  joblib 1.3.0 issue temporarily. Solution is joblib/joblib-spark#48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'joblibspark._parallel_backends'
2 participants