Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temp solution for joblib 1.3.0 issue #1100

Merged
merged 2 commits into from
Jun 30, 2023
Merged

temp solution for joblib 1.3.0 issue #1100

merged 2 commits into from
Jun 30, 2023

Conversation

thinkall
Copy link
Collaborator

@thinkall thinkall commented Jun 29, 2023 •
edited
Loading

Why are these changes needed?

To fix spark parallel training errors.

Temp solution for joblib 1.3.0 issue, no need once joblib/joblib-spark#48 is merged

Related issue number

Closes #1102

Checks

@thinkall thinkall mentioned this pull request Jun 29, 2023
Closed
@thinkall thinkall requested a review from levscaut June 29, 2023 13:44
sonichi
sonichi suggested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to the option which needs joblib. Don't add it here.

@thinkall thinkall requested a review from sonichi June 29, 2023 23:48
@qingyun-wu qingyun-wu added this pull request to the merge queue Jun 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 30, 2023
@sonichi sonichi added this pull request to the merge queue Jun 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 30, 2023
@thinkall thinkall added this pull request to the merge queue Jun 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 30, 2023
@sonichi sonichi added this pull request to the merge queue Jun 30, 2023
Merged via the queue into microsoft:main with commit aa05434 Jun 30, 2023
@thinkall thinkall deleted the support_joblib_1.3.0 branch July 1, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonichi sonichi sonichi approved these changes

@qingyun-wu qingyun-wu qingyun-wu approved these changes

@levscaut levscaut levscaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallel tuning with Spark is no longer possible if joblib isn't pinned to < 1.3.0
4 participants
@thinkall @sonichi @qingyun-wu @levscaut