locale pt-BR fixed official cellphone_formats and PhoneNumberProvider without DDD #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without DDD https://en.wikipedia.org/wiki/Telephone_numbers_in_Brazil All phone numbers must have the DDD
fcurella
requested changes
Mar 2, 2020
fcurella
requested changes
Mar 3, 2020
| assert msisdn.isdigit() | ||
| assert msisdn[0:4] in formats | ||
| re.match(r"^[+]?([0-9]{2})?[ ]?[(]?[0]?\d{2}[)]?[ ]?[09]?[ ]?\d{4}[ -]?\d{4}$", msisdn) | ||
|
|
There was a problem hiding this comment.
per pep8, we only keep one line between methods. Could you remove this empty line?
There was a problem hiding this comment.
Sure, didn't notice it.
It would be a good thing to set up pep8 verification on CI, with flake8 or some other lib
There was a problem hiding this comment.
We already have it in Travis
fcurella
approved these changes
Mar 5, 2020
|
Thank you! ✨ |
fcurella
added a commit
that referenced
this pull request
Mar 27, 2020
* Added company_vat faker * ISSUE-1123 handle leap day year shifts (#1124) When Faker attempts to generate a date_of_birth on 29th of February on the leap year it fails if it tries to return a year that is not also a leap year. This patch fixes the issue by extracting the year adjust to its own function that catches the ValueError and if the starting date is YYYY-02-29 it will adjust the date to YYYY-03-01. * Add generating random french licence plates (#1122) * Add initial failing test * Add french car licence plates * Fixed flake8 issue * Removed one source to pass flake8 tests Co-authored-by: Simon Persson <simon@akep.se> * Add HTTP methods random generator (#1119) * Add HTTP methods generator * Add tests for HTTP methods generator * Fix years in CHANGELOG.rst (#1127) * locale pt-BR fixed official cellphone_formats and PhoneNumberProvider without DDD (#1121) * 📝 Update CHANGELOG * Bump version: 4.0.1 → 4.0.2 * MSISDN is mobile number only (#1132) * Add dga by date (#1136) * Add Domain Generator Algorithm (DGA) by date * Add Domain Generator Algorithm (DGA) by date test * #1131 Fixes issue where pydict provider was not returing the correct number of elements. (#1137) * Adds support for Indian Aadhaar numbers (#1138) * Adds support for Indian Aadhaar numbers This change also introduces the en_IN locale. As we needed to use a Luhn check - moved an existing implementation to utils along with additional tests * Sort imports and changes for flake8 rules Co-authored-by: Dinu Nair <dinunair@gmail.com> Co-authored-by: Dinu Nair <dinu@esthenos.com> * Removing spaces * Added company_vat faker * Removing spaces * Use checkum calculator from commont utils * standardizing imports Co-authored-by: Marco <marco@esplores.com> Co-authored-by: Matt McMahon <matt.mcmahon@gmail.com> Co-authored-by: clarissedescamps <clarisse.descamps96@yahoo.fr> Co-authored-by: Simon Persson <simon@akep.se> Co-authored-by: Roman Pishchalnikov <roman.pishchalnikov@gmail.com> Co-authored-by: Laurent Bristiel <laurent@bristiel.com> Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com> Co-authored-by: fcurella <flavio.curella@gmail.com> Co-authored-by: Rodrigo Castro <rodrigondec@gmail.com> Co-authored-by: mstellon <39681459+mstellon@users.noreply.github.com> Co-authored-by: curiousElf <dinunair+github@gmail.com> Co-authored-by: Dinu Nair <dinunair@gmail.com> Co-authored-by: Dinu Nair <dinu@esthenos.com>
IlfirinPL
pushed a commit
to IlfirinPL/faker
that referenced
this pull request
Apr 9, 2021
IlfirinPL
pushed a commit
to IlfirinPL/faker
that referenced
this pull request
Apr 9, 2021
* Added company_vat faker * ISSUE-1123 handle leap day year shifts (joke2k#1124) When Faker attempts to generate a date_of_birth on 29th of February on the leap year it fails if it tries to return a year that is not also a leap year. This patch fixes the issue by extracting the year adjust to its own function that catches the ValueError and if the starting date is YYYY-02-29 it will adjust the date to YYYY-03-01. * Add generating random french licence plates (joke2k#1122) * Add initial failing test * Add french car licence plates * Fixed flake8 issue * Removed one source to pass flake8 tests Co-authored-by: Simon Persson <simon@akep.se> * Add HTTP methods random generator (joke2k#1119) * Add HTTP methods generator * Add tests for HTTP methods generator * Fix years in CHANGELOG.rst (joke2k#1127) * locale pt-BR fixed official cellphone_formats and PhoneNumberProvider without DDD (joke2k#1121) * 📝 Update CHANGELOG * Bump version: 4.0.1 → 4.0.2 * MSISDN is mobile number only (joke2k#1132) * Add dga by date (joke2k#1136) * Add Domain Generator Algorithm (DGA) by date * Add Domain Generator Algorithm (DGA) by date test * joke2k#1131 Fixes issue where pydict provider was not returing the correct number of elements. (joke2k#1137) * Adds support for Indian Aadhaar numbers (joke2k#1138) * Adds support for Indian Aadhaar numbers This change also introduces the en_IN locale. As we needed to use a Luhn check - moved an existing implementation to utils along with additional tests * Sort imports and changes for flake8 rules Co-authored-by: Dinu Nair <dinunair@gmail.com> Co-authored-by: Dinu Nair <dinu@esthenos.com> * Removing spaces * Added company_vat faker * Removing spaces * Use checkum calculator from commont utils * standardizing imports Co-authored-by: Marco <marco@esplores.com> Co-authored-by: Matt McMahon <matt.mcmahon@gmail.com> Co-authored-by: clarissedescamps <clarisse.descamps96@yahoo.fr> Co-authored-by: Simon Persson <simon@akep.se> Co-authored-by: Roman Pishchalnikov <roman.pishchalnikov@gmail.com> Co-authored-by: Laurent Bristiel <laurent@bristiel.com> Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com> Co-authored-by: fcurella <flavio.curella@gmail.com> Co-authored-by: Rodrigo Castro <rodrigondec@gmail.com> Co-authored-by: mstellon <39681459+mstellon@users.noreply.github.com> Co-authored-by: curiousElf <dinunair+github@gmail.com> Co-authored-by: Dinu Nair <dinunair@gmail.com> Co-authored-by: Dinu Nair <dinu@esthenos.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.wikipedia.org/wiki/Telephone_numbers_in_Brazil
All phone numbers must have the DDD
What does this changes
The variation of phone_number generation on locale pt-BR
What was wrong
PhoneNumber formats
the format '####-####' is a bad practice (without DDD)
msisdn_formats
the format '55AA#########' is wrong because in the example '55AA412345678' the char at position 4 is only acceptable as a '9' digit else if must not exist this additional char.
it must be '55AA12345678' or '55AA912345678'
cellphone_formats
the format '+55 9#### ####' is wrong because is missing DDD, the correct would be '+55 ## 9#### ####'.
How this fixes it
It fixes these issues by correcting the formats for random_element generation