Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dga by date #1136

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Add dga by date #1136

merged 2 commits into from
Mar 19, 2020

Conversation

pishchalnikov
Copy link
Contributor

What does this changes

Add Domain Generator Algorithm by date method and test for it

@fcurella
Copy link
Collaborator

Good idea! Thank you!

@fcurella fcurella merged commit 8ce4c09 into joke2k:master Mar 19, 2020
fcurella added a commit that referenced this pull request Mar 27, 2020
* Added company_vat faker

* ISSUE-1123 handle leap day year shifts (#1124)

When Faker attempts to generate a date_of_birth on 29th of February on the leap year it fails  if it tries to return a year that is not also a leap year.

This patch fixes the issue by extracting the year adjust to its own function that catches the ValueError and if the starting date is YYYY-02-29 it will adjust the date to YYYY-03-01.

* Add generating random french licence plates (#1122)

* Add initial failing test

* Add french car licence plates

* Fixed flake8 issue

* Removed one source to pass flake8 tests

Co-authored-by: Simon Persson <simon@akep.se>

* Add HTTP methods random generator (#1119)

* Add HTTP methods generator

* Add tests for HTTP methods generator

* Fix years in CHANGELOG.rst (#1127)

* locale pt-BR fixed official cellphone_formats and PhoneNumberProvider without DDD (#1121)

* 📝 Update CHANGELOG

* Bump version: 4.0.1 → 4.0.2

* MSISDN is mobile number only (#1132)

* Add dga by date (#1136)

* Add Domain Generator Algorithm (DGA) by date

* Add Domain Generator Algorithm (DGA) by date test

* #1131 Fixes issue where pydict provider was not returing the correct number of elements. (#1137)

* Adds support for Indian Aadhaar numbers (#1138)

* Adds support for Indian Aadhaar numbers

This change also introduces the en_IN locale.

As we needed to use a Luhn  check - moved an existing implementation
to utils along with additional tests

* Sort imports and changes for flake8 rules

Co-authored-by: Dinu Nair <dinunair@gmail.com>
Co-authored-by: Dinu Nair <dinu@esthenos.com>

* Removing spaces

* Added company_vat faker

* Removing spaces

* Use checkum calculator from commont utils

* standardizing imports

Co-authored-by: Marco <marco@esplores.com>
Co-authored-by: Matt McMahon <matt.mcmahon@gmail.com>
Co-authored-by: clarissedescamps <clarisse.descamps96@yahoo.fr>
Co-authored-by: Simon Persson <simon@akep.se>
Co-authored-by: Roman Pishchalnikov <roman.pishchalnikov@gmail.com>
Co-authored-by: Laurent Bristiel <laurent@bristiel.com>
Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com>
Co-authored-by: fcurella <flavio.curella@gmail.com>
Co-authored-by: Rodrigo Castro <rodrigondec@gmail.com>
Co-authored-by: mstellon <39681459+mstellon@users.noreply.github.com>
Co-authored-by: curiousElf <dinunair+github@gmail.com>
Co-authored-by: Dinu Nair <dinunair@gmail.com>
Co-authored-by: Dinu Nair <dinu@esthenos.com>
IlfirinPL pushed a commit to IlfirinPL/faker that referenced this pull request Apr 9, 2021
* Add Domain Generator Algorithm (DGA) by date

* Add Domain Generator Algorithm (DGA) by date test
IlfirinPL pushed a commit to IlfirinPL/faker that referenced this pull request Apr 9, 2021
* Added company_vat faker

* ISSUE-1123 handle leap day year shifts (joke2k#1124)

When Faker attempts to generate a date_of_birth on 29th of February on the leap year it fails  if it tries to return a year that is not also a leap year.

This patch fixes the issue by extracting the year adjust to its own function that catches the ValueError and if the starting date is YYYY-02-29 it will adjust the date to YYYY-03-01.

* Add generating random french licence plates (joke2k#1122)

* Add initial failing test

* Add french car licence plates

* Fixed flake8 issue

* Removed one source to pass flake8 tests

Co-authored-by: Simon Persson <simon@akep.se>

* Add HTTP methods random generator (joke2k#1119)

* Add HTTP methods generator

* Add tests for HTTP methods generator

* Fix years in CHANGELOG.rst (joke2k#1127)

* locale pt-BR fixed official cellphone_formats and PhoneNumberProvider without DDD (joke2k#1121)

* 📝 Update CHANGELOG

* Bump version: 4.0.1 → 4.0.2

* MSISDN is mobile number only (joke2k#1132)

* Add dga by date (joke2k#1136)

* Add Domain Generator Algorithm (DGA) by date

* Add Domain Generator Algorithm (DGA) by date test

* joke2k#1131 Fixes issue where pydict provider was not returing the correct number of elements. (joke2k#1137)

* Adds support for Indian Aadhaar numbers (joke2k#1138)

* Adds support for Indian Aadhaar numbers

This change also introduces the en_IN locale.

As we needed to use a Luhn  check - moved an existing implementation
to utils along with additional tests

* Sort imports and changes for flake8 rules

Co-authored-by: Dinu Nair <dinunair@gmail.com>
Co-authored-by: Dinu Nair <dinu@esthenos.com>

* Removing spaces

* Added company_vat faker

* Removing spaces

* Use checkum calculator from commont utils

* standardizing imports

Co-authored-by: Marco <marco@esplores.com>
Co-authored-by: Matt McMahon <matt.mcmahon@gmail.com>
Co-authored-by: clarissedescamps <clarisse.descamps96@yahoo.fr>
Co-authored-by: Simon Persson <simon@akep.se>
Co-authored-by: Roman Pishchalnikov <roman.pishchalnikov@gmail.com>
Co-authored-by: Laurent Bristiel <laurent@bristiel.com>
Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com>
Co-authored-by: fcurella <flavio.curella@gmail.com>
Co-authored-by: Rodrigo Castro <rodrigondec@gmail.com>
Co-authored-by: mstellon <39681459+mstellon@users.noreply.github.com>
Co-authored-by: curiousElf <dinunair+github@gmail.com>
Co-authored-by: Dinu Nair <dinunair@gmail.com>
Co-authored-by: Dinu Nair <dinu@esthenos.com>
@pishchalnikov pishchalnikov deleted the add-dga-by-date branch June 16, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants