Added Posh-ACME to client list #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you feel that it's ready, we can add it. I would prefer the client list to be in alphabetical order however. |
|
It's definitely working. But it's probably best to wait for the release so that people getting the client through the normal PowerShell Gallery channel will have the plugin. |
|
Ok, sounds good. LMK when it's ready. |
joohoi
approved these changes
Apr 30, 2018
|
Posh-ACME 1.1 is now released to the PowerShell Gallery and contains acme-dns support. All good to merge this. |
|
Nice! Merged |
jacobmyers-codeninja
pushed a commit
to jacobmyers-codeninja/acme-dns
that referenced
this pull request
Sep 30, 2020
* Added Posh-ACME to client list * alphabetical order as requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just merged the first version of the acme-dns plugin for Posh-ACME via rmbolger/Posh-ACME#4. So it's in the master branch, but I'm hoping to get a few more plugins written before making a new official release. I understand if you want to wait to accept this PR until that happens.