Initial Acme-Dns plugin #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
AcmeDnsplugin which addresses issue #1 and #2.This is likely going to be a fairly unique plugin because of the intended acme-dns workflow. When a cert is first created, each name will have a new acme-dns "registration" which generates a unique subdomain on the acme-dns server. Those subdomains need to be manually registered as CNAMEs targets for their associated challenge records. So the plugin will display an interactive prompt informing the user of what records to add and pause waiting for the user to press a key.
After that, things proceed as normal. Renewals and new orders with the same names do not require user interaction because the CNAMEs have already been created and the credentials are saved to the account profile just like other plugin parameters.