[3.x] Fix unignorable phpstan errors #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
changed the title
Contributor
|
this is a b/c break |
Contributor
Author
@HLeithner So should we have chosen PR #29 instead? I see no other way as this one here or that one because the PHPStan errors were of the not ignorable type. |
Contributor
|
yes #29 is the correct way to do it. |
Contributor
Author
|
Thanks for checking. I will fix it tomorrow if nobody else is faster. |
richard67
added a commit
that referenced
this pull request
Jul 13, 2025
This reverts commit 99f72e0.
Contributor
Author
|
Reverted with commit b36bd44 . |
Contributor
|
@HLeithner what is the b/c break here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to PR #29 .
Summary of Changes
Fix unignorable PHPStan errors.
Another way to fix these errors would be PR #29 .
For the remaining, ignorable errors, the baseline was backported from 4.x-dev with commit 9d7c5c8 and adapted to 3.x-dev with commit f92ec43 .
@Hackwar @rdeutz Can we do it that way to make phpstan pass in 3.x-dev? Or are the method singature changes b/c breaks?