[3.x] Add ReturnTypeWillChange attribute to methods where return types will be fixed in 4.x-dev #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ReturnTypeWillChange attribute to method where we will fix return types in 4,x-dev. The attribute will be removed again in 4.x-dev.
Contributor
|
fixed with #28 |
Contributor
Author
|
#28 had to be reverted, so I've reopened this one. |
Contributor
|
can you create documentation for this upcoming b/c break please? |
Contributor
Author
@HLeithner Will be done soon. Do I assume right that the documentation would be for migration from framework v3 to v4? The changes (differences between 3.x-dev and 4.x-dev) can be seen here: 67f27ee |
Contributor
Author
|
@HLeithner P.S.: Additional question: Does it also need some deprecation comments in code in 3.x-dev? |
Contributor
|
yes, because we want to change this in future version (4.0?) |
Contributor
Author
|
Would be good to have some example somewhere. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to PR #28 .
Fix unignorable PHPStan errors in 3.x-dev by adding the ReturnTypeWillChange attribute.
The attribute will be removed again (or not be added) in 4.x-dev.
Another way to fix the unignorable PHPStan errors would be PR #28 .