Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassiopeia: Top margin of system message container #40639

Closed
Tom582 opened this issue May 21, 2023 · 8 comments
Closed

Cassiopeia: Top margin of system message container #40639

Tom582 opened this issue May 21, 2023 · 8 comments

Comments

@Tom582
Copy link

Tom582 commented May 21, 2023

Hi,

Sorry for adding this new cassiopeia issue here, but the cassiopeia repository has been archived a while ago and I would like to report a new issue related to cassiopeia.

Steps to reproduce the issue

  1. Login at the frontend of a Joomla website running cassiopeia in order to create a joomla-alert
  2. A green alert is displayed to confirm a successful login
  3. Close the alert by clicking on the green X
  4. After the alert has been closed the contents of the main section is offset by 1em with respect to its original state before the login
  5. Press F5 in the browser window in order to remove the additional offset and have the original contents of the main section restored

Expected result

After closing the alert by clicking on the green X, the original contents of the main section should be restored without any extra offset

Actual result

See step 4 mentioned above

System information (as much as possible)

  • OS: Linux
  • Joomla! Version 4.3.1
  • PHP Version 8.0.28
  • Template cassiopeia override
  • Server mysql 5.7.41

Additional comments

More explanations on this issue can be found in the Joomla forum

Regards
Tom

@sandewt
Copy link
Contributor

sandewt commented May 21, 2023

Sorry Tom, but the link to the forum does not redirect correctly.
Schermafbeelding 2023-05-21 173907

@Tom582
Copy link
Author

Tom582 commented May 21, 2023

You are right :-(. Actually, I had noticed that issue and was struggeling with the URL command, but wanted to submit the issue before lunch. So I did not try to find and fix the root cause. I should have read the github editor user's manual. I hope, this time it does work correctly:

More explanations on this issue can be found in the Joomla forum

Thanks
Tom

@richard67 richard67 added the bug label May 21, 2023
@chmst
Copy link
Contributor

chmst commented May 22, 2023

Confirmed. But should be solved with #40539 which removes the login message.

@brianteeman
Copy link
Contributor

@chmst the login message given as just an example of a problem with all alerts. You can see the same for example when you send an email using the contact form

@brianteeman
Copy link
Contributor

The problem is created because dismissing the alert does not remove the version of the alert and this gets a margin-top of 1em

@brianteeman
Copy link
Contributor

This was fixed originally by @hans2103 joomla/cassiopeia#194

@Tom582
Copy link
Author

Tom582 commented Jun 14, 2023

Just to avoid any misunderstandings. The reported issue is not fixed and still persists in 4.3.2.

@richard67
Copy link
Member

Closing as having a pull request. See #44222 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants