[4.3] Remove message on login #40539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the message when a user logs in
Removed frontend login message
|
Looks good for me. |
4 tasks
brianteeman
reviewed
May 4, 2023
Deprecate string, do not delete it
This comment was marked as outdated.
This comment was marked as outdated.
|
I have tested this item ✅ successfully on 32dad37 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40539. |
|
I have tested this item ✅ successfully on 32dad37 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40539. |
|
I have tested this item ✅ successfully on 32dad37 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40539. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40539. |
|
Thanks Olivier |
Merged
|
Hi guys, |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jun 1, 2023
В Joomla 4.3.1 не было изменений в локализации. Новое в Joomla 4.3.2 Stable joomla/joomla-cms#40258 + joomla/joomla-cms#40266 - (только для en-GB) joomla/joomla-cms#40471 - (только для en-GB) joomla/joomla-cms#40304 + joomla/joomla-cms#40401 - (только для en-GB) joomla/joomla-cms#40299 - (только для en-GB) joomla/joomla-cms#40539 + joomla/joomla-cms#40377 + joomla/joomla-cms@0b162d3 + (коммит без PR) + другие мелкие исправления
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #40531 as an answer to issue #40458.
Summary of Changes
A quick solution seems to be the removal of the message when users log in.
It does not completely revert PR #30834, as messaging users when they log out does add feedback to users they did not have before.
The log out message can easily be adapted via the use of a language override.
Testing Instructions
Login and logout of a website in the frontend.
Actual result BEFORE applying this Pull Request
You have a message when logging in and a message when logging out.
Expected result AFTER applying this Pull Request
There is no longer a message when the user logs in except for the initial feedback users used to get in prior versions.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed