Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3] Guided Tours add full stop to description #40401

Merged
merged 3 commits into from
May 6, 2023
Merged

[4.3] Guided Tours add full stop to description #40401

merged 3 commits into from
May 6, 2023

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 17, 2023

Summary of Changes

all other descriptions for guided tours have a full stop at the end

Testing Instructions

code review

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Apr 17, 2023
@heelc29 heelc29 mentioned this pull request Apr 17, 2023
Merged
@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 97dd584

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40401.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Apr 17, 2023

I have tested this item ✅ successfully on 97dd584

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40401.

@Quy Quy removed the Language Change This is for Translators label Apr 17, 2023
@Quy
Copy link
Contributor

Quy commented Apr 17, 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40401.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 17, 2023
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label May 6, 2023
@obuisard obuisard added this to the Joomla! 4.3.2 milestone May 6, 2023
@obuisard obuisard merged commit aeeaf85 into joomla:4.3-dev May 6, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 6, 2023
@obuisard
Copy link
Contributor

obuisard commented May 6, 2023

Thank you @heelc29 !

@jgerman-bot jgerman-bot mentioned this pull request May 7, 2023
Closed
@joomlapl-bot joomlapl-bot mentioned this pull request May 7, 2023
Closed
@heelc29 heelc29 deleted the 4.3/guided-tours-banners-description branch May 7, 2023 08:35
Kostelano added a commit to JPathRu/localisation that referenced this pull request Jun 1, 2023
@Kostelano
Новое в Joomla 4.3.2 Stable
dbec350 
В Joomla 4.3.1 не было изменений в локализации.

Новое в Joomla 4.3.2 Stable
joomla/joomla-cms#40258 +
joomla/joomla-cms#40266 - (только для en-GB)
joomla/joomla-cms#40471 - (только для en-GB)
joomla/joomla-cms#40304 +
joomla/joomla-cms#40401 - (только для en-GB)
joomla/joomla-cms#40299 - (только для en-GB)
joomla/joomla-cms#40539 +
joomla/joomla-cms#40377 +
joomla/joomla-cms@0b162d3 + (коммит без PR)
+ другие мелкие исправления
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecpromotion tecpromotion tecpromotion approved these changes

Assignees
No one assigned
Labels
Language Change This is for Translators
Projects
None yet
Milestone
Joomla! 4.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@heelc29 @tecpromotion @Quy @obuisard @joomla-cms-bot