Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3][Guided Tours] Fixed missing field in Banners Tour #40258

Merged
merged 12 commits into from
May 5, 2023

Conversation

khu5h1
Copy link
Contributor

@khu5h1 khu5h1 commented Mar 30, 2023

Pull Request for Issue #40210 .

Summary of Changes

Fixed missing field in Banners Tour.

Actual result BEFORE applying this Pull Request

When we go through the tutorial on how to create a banner, there are skipping fields, some of which are required.

Expected result AFTER applying this Pull Request

Now, it does not skip the fields and targets the entire details.

image

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Mar 30, 2023
@richard67
Copy link
Member

@khu5h1 Please do it like I suggest, update the values with one common update statement and use only the ID in the WHERE clause:

UPDATE `#__guidedtour_steps`
SET `title` = 'COM_GUIDEDTOURS_TOUR_BANNERS_STEP_DETAILS_TITLE', `description` = 'COM_GUIDEDTOURS_TOUR_BANNERS_STEP_DETAILS_DESCRIPTION', `target` = '.col-lg-9'
WHERE `id` = 63;

@khu5h1
Copy link
Contributor Author

khu5h1 commented Apr 1, 2023

@richard67 sure, updating the changes.

khu5h1 and others added 3 commits April 1, 2023 20:31
…0-2023-03-31.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…3-03-31.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 1, 2023
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 1e366a7

It's all right now, thanks. A little generalized (large) field with details, but it's better than it was ;).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40258.

@Quy
Copy link
Contributor

Quy commented Apr 1, 2023

I have tested this item ✅ successfully on 1e366a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40258.

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 1, 2023
@Quy
Copy link
Contributor

Quy commented Apr 1, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40258.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 1, 2023
@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 1, 2023
@Hackwar Hackwar added the bug label Apr 8, 2023
@sdwjoomla sdwjoomla merged commit 10be8d6 into joomla:4.3-dev May 5, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 5, 2023
@sdwjoomla
Copy link
Contributor

Thanks khu5h1

@sdwjoomla sdwjoomla added this to the Joomla! 4.3.2 milestone May 5, 2023
heelc29 added a commit to heelc29/joomla that referenced this pull request May 7, 2023
Kostelano added a commit to JPathRu/localisation that referenced this pull request Jun 1, 2023
В Joomla 4.3.1 не было изменений в локализации.

Новое в Joomla 4.3.2 Stable
joomla/joomla-cms#40258 +
joomla/joomla-cms#40266 - (только для en-GB)
joomla/joomla-cms#40471 - (только для en-GB)
joomla/joomla-cms#40304 +
joomla/joomla-cms#40401 - (только для en-GB)
joomla/joomla-cms#40299 - (только для en-GB)
joomla/joomla-cms#40539 +
joomla/joomla-cms#40377 +
joomla/joomla-cms@0b162d3 + (коммит без PR)
+ другие мелкие исправления
tecpromotion pushed a commit to joomlagerman/joomla that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants