-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3][Guided Tours] Fixed missing field in Banners Tour #40258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
requested changes
Mar 30, 2023
administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-03-31.sql
Outdated
Show resolved
Hide resolved
administrator/components/com_admin/sql/updates/postgresql/4.3.0-2023-03-31.sql
Outdated
Show resolved
Hide resolved
richard67
added
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Mar 30, 2023
richard67
reviewed
Apr 1, 2023
administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-03-31.sql
Outdated
Show resolved
Hide resolved
richard67
reviewed
Apr 1, 2023
administrator/components/com_admin/sql/updates/postgresql/4.3.0-2023-03-31.sql
Outdated
Show resolved
Hide resolved
@khu5h1 Please do it like I suggest, update the values with one common update statement and use only the ID in the WHERE clause:
|
@richard67 sure, updating the changes. |
richard67
reviewed
Apr 1, 2023
administrator/components/com_admin/sql/updates/mysql/4.3.0-2023-03-31.sql
Outdated
Show resolved
Hide resolved
richard67
reviewed
Apr 1, 2023
administrator/components/com_admin/sql/updates/postgresql/4.3.0-2023-03-31.sql
Outdated
Show resolved
Hide resolved
…0-2023-03-31.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…3-03-31.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
approved these changes
Apr 1, 2023
richard67
removed
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Apr 1, 2023
I have tested this item ✅ successfully on 1e366a7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40258. |
I have tested this item ✅ successfully on 1e366a7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40258. |
Quy
added
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Apr 1, 2023
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40258. |
richard67
removed
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Apr 1, 2023
Thanks khu5h1 |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
May 7, 2023
2 tasks
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Jun 1, 2023
В Joomla 4.3.1 не было изменений в локализации. Новое в Joomla 4.3.2 Stable joomla/joomla-cms#40258 + joomla/joomla-cms#40266 - (только для en-GB) joomla/joomla-cms#40471 - (только для en-GB) joomla/joomla-cms#40304 + joomla/joomla-cms#40401 - (только для en-GB) joomla/joomla-cms#40299 - (только для en-GB) joomla/joomla-cms#40539 + joomla/joomla-cms#40377 + joomla/joomla-cms@0b162d3 + (коммит без PR) + другие мелкие исправления
tecpromotion
pushed a commit
to joomlagerman/joomla
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #40210 .
Summary of Changes
Fixed missing field in Banners Tour.
Actual result BEFORE applying this Pull Request
When we go through the tutorial on how to create a banner, there are skipping fields, some of which are required.
Expected result AFTER applying this Pull Request
Now, it does not skip the fields and targets the entire details.