[4.3] Message after a login / logout frontend

[sandewt]

Pull Request for Issue # .

New feature, see #30767

Summary of Changes

There is a message after a successfully login and logout in the frontend.

Messages

[EDIT] Removed successfully from the text in message.

Users: Options

[EDIT] Removed

Testing Instructions

Backend: Go to Users > Manage > Options
(Frontend: Is not applicable.)

Set the options:

• Frontend Login Message (= Yes, default = No)
• Frontend Logout Message (= Yes, default = No)

Create a menu link:

• Menu Login form
• Menu Logout form

1. Log in and out, in case of a:

• Login form (default)
• Menu Login form
• Menu Logout form

2. Code review (developers);

• Check if the code is correct and secure.

Actual result BEFORE applying this Pull Request

There is NOT showing a message after a suscessfully login or logout.

Expected result AFTER applying this Pull Request

• There is showing a message after a suscessfully login.
• There is showing a message after a suscessfully logout.

Documentation Changes Required

Yes.

[HLeithner]

Please rebase on 4.1-dev

[sandewt]

Please rebase on 4.1-dev

It's just a small extension, a new feature might be a bit exaggerated. Or is there some other argument?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30834.}

[maikol-ortigueira]

I have tested this item ✅ successfully on 963ad7d

I have tested the patch and it works perfectly

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30834.}

[pabloarias]

I have tested this item ✅ successfully on 963ad7d

Tested successfully on Joomla 4.0.0-beta5-dev and PHP 7.3.22-1

Thank you!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30834.}

[alikon]

i'll not set this PR as RTC despite 2 good tests cause of #30834 (comment)
i'll let the final decision to RL's

[brianteeman]

We might as well all go home if this wont get merged

[sandewt]

Some checks were not successful: continuous-integration/drone/pr — Build is failing

What does this mean? Action?

[EDIT] I see that this problem has resolved itself.

[HLeithner]

We might as well all go home if this wont get merged

We have 27 release blocker and most of the time I only see some new stuff if no one fixes the release blocker and only add new fancy stuff then you are right and we can go home.
https://github.com/joomla/joomla-cms/issues?q=is%3Aopen+is%3Aissue+label%3A"Release+Blocker"

[sandewt]

We have 27 release blocker and most of the time I only see some new stuff if no one fixes the release blocker and only add new fancy stuff then you are right and we can go home.

I will close this PR and make a new PR based on [4.1].

[HLeithner]

You don't need to, I changed your target branch to 4.1-dev

[sandewt]

You don't need to, I changed your target branch to 4.1-dev

I see it has already happened. 😃

Thanks.

[drmenzelit]

Thanks

[sandewt]

Your comment here #30834 (comment) may need some further investigation in a separate issue.

@drmenzelit

Something went wrong here. This PR is merged to joomla 4.3. That shouldn't have happened.
Because this PR is not working.

[sandewt]

Removing the if statement makes this PR work. The question is whether that is desirable. See the discussion above.

Change this:

// Show a message when a user is logged out.
if ($app->getIdentity()->guest) {
    $app->enqueueMessage(Text::_('COM_USERS_FRONTEND_LOGOUT_SUCCESS'), 'message');
}

To:

// Show a message when a user is logged out.
$app->enqueueMessage(Text::_('COM_USERS_FRONTEND_LOGOUT_SUCCESS'), 'message');

[bembelimen]

Please test #39048

[richard67]

@sandewt Please test #39048 . Thanks in advance.

[sandewt]

@richard67

I'd like to do that, but then I'm actually testing my own code proposal. I wonder if that's desirable 😉