[J5.2] Cassiopeia - Only add margin to system message container if it contains a joomla-alert #44222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #40639.
Summary of Changes
Added a :has rule to control the margin of the system-message-container if it does not contain a tag
:has selector is supported by all modern browsers
Testing Instructions
login with wrong credentials in your cassiopeia frontend.
A system message appears that the login data is wrong
Click the close button to hide the message
Actual result BEFORE applying this Pull Request
After hiding a system alert, a margin of 1rem remains
Expected result AFTER applying this Pull Request
After hiding a system alert, the margin is not present anymore
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[x ] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[x ] No documentation changes for manual.joomla.org needed