Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[J5.2] Cassiopeia - Only add margin to system message container if it contains a joomla-alert #44222

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

coolcat-creations
Copy link
Contributor

Pull Request for Issue #40639.

Summary of Changes

Added a :has rule to control the margin of the system-message-container if it does not contain a tag
:has selector is supported by all modern browsers

grafik

Testing Instructions

login with wrong credentials in your cassiopeia frontend.
A system message appears that the login data is wrong
Click the close button to hide the message

Actual result BEFORE applying this Pull Request

After hiding a system alert, a margin of 1rem remains

Expected result AFTER applying this Pull Request

After hiding a system alert, the margin is not present anymore

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [x ] No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Oct 10, 2024
@fgsw
Copy link

fgsw commented Oct 10, 2024

I have tested this item ✅ successfully on 97d0209


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 97d0209

with NPM Package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 10, 2024
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 97d0209


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.

@pe7er pe7er self-assigned this Oct 26, 2024
@pe7er pe7er enabled auto-merge (squash) October 26, 2024 15:56
@pe7er pe7er merged commit 2d4547e into joomla:5.2-dev Oct 26, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 26, 2024
@Quy Quy added this to the Joomla! 5.2.1 milestone Oct 26, 2024
@pe7er
Copy link
Contributor

pe7er commented Oct 26, 2024

Thanks @coolcat-creations !

@coolcat-creations
Copy link
Contributor Author

Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants