PluginHelper::getPlugin returns array as default - object expected

[brbrbr]

Steps to reproduce the issue

Disable the SEF plugin and enable maximum login

Expected result

No warnings

Actual result

Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php

System information (as much as possible)

Joomla 5.2

Additional comments

PluginHelper::getPlugin should probably return an empty object for $plugin !== null

[Fedik]

As result of:

• [5.2] SEF: Add option to don't set Itemid to homepage by default #42989

[Hackwar]

What does #42989 have to do with this?

Yes, the method sucks and eventually we should replace this with 2 methods instead of just one, but the behavior is correct. PluginHelper::getPlugin() states that it either returns an object or an array of objects. We can keep this ticket open to create another method PluginHelper::getPlugins() to solve this.

[Hackwar]

Ok, I understand what one has to do with the other. I'll create a PR to fix that. In the meantime I created #44282 to introduce a new method for retrieving a list of plugins. Thanks for reporting this.