[6.0] Add PluginHelper::getPlugins() and deprecate old behavior #44282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Oct 16, 2024
| $result[] = $p; | ||
| } | ||
| } | ||
| return self::getPlugins($type); | ||
| } else { |
There was a problem hiding this comment.
Remove else and reduce indentation.
|
This pull request does not solve the issue of: Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php The sef plugin must be enabled, always. |
|
When I see this code, then the plugin should either be booted or the PluginsModel should be used instead of introducing another static function with deprecated global static Factory calls. |
|
This pull request has been automatically rebased to 6.0-dev. |
HLeithner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44270.
Summary of Changes
PluginHelper::getPlugin()currently returns either an (empty) array of objects or a single object. This is the first step towards cleaning that code up by splitting the code up into a method to retrieve a single plugin (getPlugin()) and an array of plugins (getPlugins()).Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed