Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] SEF URLs: Check if SEF plugin is published #44283

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Oct 16, 2024

Pull Request for Issue #44270.

Summary of Changes

The new changes for SEF URLs check the options in the SEF plugin. If the plugin is unpublished/disabled, the plugin data is not loaded and results in notices in the output if error reporting is turned up high enough.

Testing Instructions

Install 5.2 and set error reporting to maximum, as well as debugging to on. Unpublish the SEF system plugin.

Actual result BEFORE applying this Pull Request

Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php

Expected result AFTER applying this Pull Request

Nothing.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I am not up to date with 3rd party sef extensions but what if they require the core sef plugin to be disabled?

@Hackwar
Copy link
Member Author

Hackwar commented Oct 17, 2024

That is the goal of this PR to allow this.

@fgsw
Copy link

fgsw commented Oct 24, 2024

I have tested this item ✅ successfully on 1ac14e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 1ac14e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283.

@Quy
Copy link
Contributor

Quy commented Oct 31, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 31, 2024
@pe7er pe7er enabled auto-merge (squash) November 3, 2024 18:07
@pe7er pe7er merged commit cc82bbe into joomla:5.2-dev Nov 3, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 3, 2024
@Quy Quy added this to the Joomla! 5.2.1 milestone Nov 3, 2024
@pe7er
Copy link
Contributor

pe7er commented Nov 3, 2024

Thanks @Hackwar !

@Hackwar Hackwar deleted the 5.2-sef-plugin branch November 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants