New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Remove article print and email #24025

Merged

roland-d merged 8 commits into joomla:4.0-dev from brianteeman:print-email

Jun 14, 2019

Contributor

brianteeman commented Feb 26, 2019

The option to email a link to a friend and to print an article were outdated when joomla 1.0 was launched - there are far better ways to share content etc.

This pr removes the show print and email icons options and code to display the icons. (It does not remove the helpers as they haven't been deprecated)

If I understand everything correctly nothing would need to be done to update upgrading sites databases as the stored param would simply be ignored

Resurrection of PR#19393


          [4.0] Remove article print and email

56582d3

The option to email a link to a friend and to print an article were outdated when joomla 1.0 was launched - there are far better ways to share content etc.

This pr removes the show print and email icons options and code to display the icons. (It does not remove the helpers as they haven't been deprecated)

If I understand everything correctly nothing would need to be done to update upgrading sites databases as the stored param would simply be ignored

Resurrection of PR#19393

joomla-cms-bot added Language Change PR-4.0-dev labels

brianteeman mentioned this pull request

[4.0] Remove article print and email #19393

Closed

Quy reviewed

View reviewed changes

components/com_content/tmpl/article/default.php Outdated Show resolved Hide resolved

Quy reviewed

View reviewed changes

layouts/joomla/content/icons.php Outdated Show resolved Hide resolved

Quy and others added 2 commits

February 26, 2019 19:34


          Update components/com_content/tmpl/article/default.php

12630a3

oops - thought I did that - guess i forgot

Co-Authored-By: brianteeman <brian@teeman.net>


          Update icons.php

1712c0b

thanks @Quy

Quy reviewed

View reviewed changes

components/com_content/tmpl/article/default.php Outdated Show resolved Hide resolved


          Update components/com_content/tmpl/article/default.php

a1d44e0

Co-Authored-By: brianteeman <brian@teeman.net>

Contributor

ladyjer commented Feb 26, 2019

Hi,

what about keeping .ini as is?
Maybe some extension used JGLOBAL_SHOW_EMAIL_ICON_LABEL or JGLOBAL_SHOW_PRINT_ICON_LABEL placeholders, they are pretty generics.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.}

Contributor Author

brianteeman commented Feb 26, 2019

It is not the role of Joomla to translate every possible word or sentence.

Contributor

ladyjer commented Feb 26, 2019

Hi,

show_icons and the others 2 still in installation/sql/{mysql|postgres}/sample_testing.sql files

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.}

Contributor Author

brianteeman commented Feb 26, 2019

@ladyjer Yes I know - that file is so out of date and not distributed with Joomla that at this time its hardly worth fixing.

Contributor

ladyjer commented Feb 26, 2019

I have tested this item ✅ successfully on a1d44e0

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.}

Member

Hackwar commented Feb 27, 2019

I have tested this item ✅ successfully on a1d44e0

I tested this successfully.

I love this change. It is one of the things that I disable first time whenever I set up a new site.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.}

Contributor

Quy commented Feb 27, 2019

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.}

joomla-cms-bot added the RTC label

Contributor Author

brianteeman commented Feb 28, 2019

@zero-24 please advise on the rips issue

Contributor Author

brianteeman commented Mar 3, 2019

updated branch to see if it passes rips


          Merge branch '4.0-dev' into print-email

6e26070

Contributor

zero-24 commented Mar 3, 2019

Sorry missed your mention. :( But it seams rips passes now.

ghost added the J4 Issue label

ghost removed the J4 Issue label

Member

Hackwar commented Apr 22, 2019

Can you solve the conflicts?

Contributor Author

brianteeman commented Apr 22, 2019

I can but only if it is going to be merged. Otherwise its a waste of my time

Contributor

roland-d commented May 19, 2019

Although I agree with this PR, I will leave the decision to remove this feature to @wilsonge as release lead.

Contributor

roland-d commented Jun 5, 2019

Pinging @wilsonge

Contributor

wilsonge commented Jun 7, 2019

Took a look around other websites and all their email options were simply mailto:// links. so i'm happy to remove both (print is clearly outdated in favour of print stylesheets)

Quy mentioned this pull request

Spam protection for Email Link form #20286

Closed

Member

infograf768 commented Jun 8, 2019

print is clearly outdated in favour of print stylesheets

I have clearly demonstrated in #19393 that if it indeed can be done with stylesheets when a unique article is displayed, it is just impossible to get anything usable when the article is displayed in a blog.

Whatever...

brianteeman added 2 commits

June 8, 2019 09:38


          Merge remote-tracking branch 'origin/4.0-dev' into print-email

af3223c

# Conflicts:
#	installation/sql/mysql/joomla.sql
#	installation/sql/postgresql/joomla.sql
#	layouts/joomla/content/icons/email.php
#	layouts/joomla/content/icons/print_popup.php
#	layouts/joomla/content/icons/print_screen.php

sql

58bf806

Contributor Author

brianteeman commented Jun 8, 2019

Hopefully all merge conflicts have now been resolved correctly


          Merge branch '4.0-dev' into print-email

56f6031

Contributor Author

brianteeman commented Jun 13, 2019

I really dont want to have to resolve merge conflicts again :(

roland-d merged commit af4dac1 into joomla:4.0-dev

joomla-cms-bot removed the RTC label

Contributor

roland-d commented Jun 14, 2019

Thank you

roland-d added this to the Joomla 4.0 milestone

Contributor Author

brianteeman commented Jun 14, 2019

Thanks

brianteeman deleted the print-email branch

June 14, 2019 19:10

wilsonge added the Documentation Required label

Member

Hackwar commented Jun 14, 2019

Thank you from me to both @brianteeman and @roland-d

infograf768 mentioned this pull request

[4.0] Correcting mutilingual sampledata plugin #25223

Merged

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request


          [4.0] Unused code after joomla#24025

73522a1

It seems that I removed one instance of this code for a print button but missed another one under a different condition. This code can not do anything because of joomla#24025 and I should have removed it then. This PR fixes my error

brianteeman mentioned this pull request

[4.0] Unused code after #24025 #25397

Merged

wilsonge pushed a commit that referenced this pull request


          [4.0] Unused code after #24025 (#25397)

9a7bf32

It seems that I removed one instance of this code for a print button but missed another one under a different condition. This code can not do anything because of #24025 and I should have removed it then. This PR fixes my error

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request


          [4.0] Remove com_mailto

63f789d

with joomla#24025 we removed the mail a link to a friend functionality. But I didnt remove the com_mailto component. Afaict this component was only used for the mail to friend functionality so I have now removed all traces of the component (I hope)

brianteeman mentioned this pull request

[4.0] Remove com_mailto #25516

Merged

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request


          [4.0] Remove com_mailto

37038cb

with joomla#24025 we removed the mail a link to a friend functionality. But I didnt remove the com_mailto component. Afaict this component was only used for the mail to friend functionality so I have now removed all traces of the component (I hope)

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request


          [4.0] Remove com_mailto

da017c6

with joomla#24025 we removed the mail a link to a friend functionality. But I didnt remove the com_mailto component. Afaict this component was only used for the mail to friend functionality so I have now removed all traces of the component (I hope)

pwireless commented Nov 12, 2021

Now when we want to print an article, we have to select and print selected... would be good to have a print feature.

Quy mentioned this pull request

[5.2] Articles do not have a [Print] or [Email] button. #44309

Closed

universewrld mentioned this pull request

[5.3][PWA]: [Web Share API] - Share button, bookmark button #44311

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Required Language Change