[4.0] Remove com_mailto #25516
[4.0] Remove com_mailto #25516
Conversation
joomla-cms-bot
added
Language Change
|
What about those migrating from 3.x to 4.0? Doesn't the |
|
I "think" the pr does that. For the migrating users then it will be handled by script.php at update time |
but the required changes to that file are missing in the script.php right now? I have also added the |
I meant that the script.php will be updated near to release time in one go. If you noticed you would see that there have not been any commits to that file during the development of J4 with individual PR
What documentation |
|
Maybe an dedicated page why or better that we removed it makes sense too. |
|
its not a bc issue better to spend your time making security headers actually work |
I'm sorry is there a reason to personally attact me? Can you please tell me what is the problem at the security headers? As there are already bigger changes planed when the current PR gets merged, I can check on the issues too. |
|
it doesnt work at all. |
hmm please share your configuration and the steps to reproduce with me. I have just tried it on php 7.3 with the latest build and it worked correctly, but I'm happy to debug and improve what ever is needed. Thanks :) |
|
see #25592 had to guess what to do as I couldnt find any documentation |
|
@brianteeman please can you provide testing instructions and i will test this PR so it can be accepted. I assume I can simply apply this patch then search in "manage extensions" for "mail to" and if it does not exist I can pass this PR? |
|
Do we need to install sample data? I get this error:
When trying to install the "testing" sample data I also get another error. I know that's unrelated but can you confirm it makes this test impossible. Or is the |
|
conflicts resolved. @uglyeoin that will resolve your patchtester error. As for testing instructions you got it right |
|
God almighty. Who do I have to butter up to get that tooltip off the issue number in Patchtester when I try to type it in? It's destroying my brain. |
|
I cannot apply the patch.
I have checked and this is the only patch applied, I have reverted all others. |
Are you referring to the alert? Try this: #25850 (comment) |
|
@uglyeoin report that to the patchtester repo. I cannot confirm with the old version of patchtester I use. |
|
@Quy that isn't the problem, this is the problem. joomla-extensions/patchtester#243 (comment) I suggested the solution. I'd do a pull request but I'm really not sure how to do it when it comes to compiled CSS. If someone can point me at instructions I'll give it a go. |
|
conflicts resolved |
| @@ -101,23 +100,7 @@ public function create($category, $params, $attribs = array(), $legacy = false) | |||
| */ | |||
| public function email($article, $params, $attribs = array(), $legacy = false) | |||
| { | |||
| $uri = Uri::getInstance(); | |||
There was a problem hiding this comment.
Should this be deprecated in v3.10 and remove in v4.0 like you did in #25502?
There was a problem hiding this comment.
I am not sure - ask @wilsonge
There was a problem hiding this comment.
@brianteeman I assume it is go since @wilsonge commented to deprecate & remove.
|
I have tested this item ✅ successfully on 3f180e9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25516. |
|
Is there any point in me resolving conflicts again or am I wasting my time |
|
conflicts resolved and deprecation pr created |
|
Deprecation PR merged 👍 |
|
Thanks for removing this awful feature. |
|
Finally!!!! |
with #24025 we removed the mail a link to a friend functionality. But I didnt remove the com_mailto component. Afaict this component was only used for the mail to friend functionality so I have now removed all traces of the component (I hope)